Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add SetRetryIf to remain compatible #318

Merged
merged 1 commit into from
Oct 22, 2022
Merged

refactor: add SetRetryIf to remain compatible #318

merged 1 commit into from
Oct 22, 2022

Conversation

li-jin-gou
Copy link
Member

@li-jin-gou li-jin-gou commented Oct 21, 2022

What type of PR is this?

refactor

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

添加 SetRetryIf 保持兼容

Which issue(s) this PR fixes:

@li-jin-gou li-jin-gou changed the title refactor: add SetRetryIf refactor: add SetRetryIf to remain compatible Oct 21, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 64.54% // Head: 64.57% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (8098ce0) compared to base (a8b4a97).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 8098ce0 differs from pull request most recent head 47bb526. Consider uploading reports for the commit 47bb526 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #318      +/-   ##
===========================================
+ Coverage    64.54%   64.57%   +0.03%     
===========================================
  Files           85       85              
  Lines         8315     8317       +2     
===========================================
+ Hits          5367     5371       +4     
+ Misses        2585     2583       -2     
  Partials       363      363              
Impacted Files Coverage Δ
pkg/app/client/client.go 74.35% <0.00%> (-0.97%) ⬇️
pkg/common/timer/timer.go 80.95% <0.00%> (+19.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jin-gou li-jin-gou merged commit 3a6bb4a into cloudwego:develop Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants