Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore body should not set content-length #321

Merged
merged 7 commits into from
Nov 3, 2022

Conversation

byene0923
Copy link
Member

@byene0923 byene0923 commented Oct 24, 2022

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: can refer to valyala/fasthttp#1022, fasthttp only handle ContinueReadBody(), this pr also handle ContinueReadBodyStream()
zh(optional): fasthttp 只处理了 ContinueReadBody(), 这里添加了对 ContinueReadBodyStream() 的处理 和 测试

Which issue(s) this PR fixes:

close #320

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 66.14% // Head: 66.13% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (4211ea3) compared to base (3a83d2e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #321      +/-   ##
===========================================
- Coverage    66.14%   66.13%   -0.01%     
===========================================
  Files           85       85              
  Lines         8317     8319       +2     
===========================================
+ Hits          5501     5502       +1     
- Misses        2456     2458       +2     
+ Partials       360      359       -1     
Impacted Files Coverage Δ
pkg/protocol/http1/req/request.go 61.88% <100.00%> (+1.88%) ⬆️
pkg/common/timer/timer.go 61.90% <0.00%> (-19.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@welkeyever welkeyever merged commit ea5d1db into cloudwego:develop Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

fix: ignore body should not set content-length
3 participants