Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hz): no import in handler for pb #341

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Nov 1, 2022

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

修复使用 protobuf 生成代码(主idl和依赖idl的package相同),handler 中缺少 import 的问题

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: Fix the problem of missing import in the handler when using protobuf to generate code (the package of main idl and dependent idl is the same)
zh(optional): 修复使用 protobuf 生成代码(主idl和依赖idl的package相同),handler 中缺少 import 的问题

Which issue(s) this PR fixes:

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 66.10% // Head: 66.09% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (26fa9a2) compared to base (37e5186).
Patch has no changes to coverable lines.

❗ Current head 26fa9a2 differs from pull request most recent head c072760. Consider uploading reports for the commit c072760 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #341      +/-   ##
===========================================
- Coverage    66.10%   66.09%   -0.02%     
===========================================
  Files           85       85              
  Lines         8317     8317              
===========================================
- Hits          5498     5497       -1     
- Misses        2459     2460       +1     
  Partials       360      360              
Impacted Files Coverage Δ
pkg/common/timer/timer.go 61.90% <0.00%> (-19.05%) ⬇️
pkg/common/compress/compress.go 83.80% <0.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Duslia Duslia merged commit 9327d1b into cloudwego:develop Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants