Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add prefix to no-format log print function when use system logger #364

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

li-jin-gou
Copy link
Member

@li-jin-gou li-jin-gou commented Nov 11, 2022

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

在非 format 日志打印函数中添加前缀

Which issue(s) this PR fixes:

FGYFFFF
FGYFFFF previously approved these changes Nov 11, 2022
Duslia
Duslia previously approved these changes Nov 11, 2022
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 66.59% // Head: 66.60% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (8aff564) compared to base (516c123).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #364      +/-   ##
===========================================
+ Coverage    66.59%   66.60%   +0.01%     
===========================================
  Files           89       89              
  Lines         8507     8514       +7     
===========================================
+ Hits          5665     5671       +6     
- Misses        2480     2481       +1     
  Partials       362      362              
Impacted Files Coverage Δ
pkg/protocol/http1/client.go 35.86% <0.00%> (ø)
pkg/route/engine.go 62.63% <0.00%> (ø)
pkg/common/hlog/system.go 85.93% <85.71%> (-0.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jin-gou li-jin-gou changed the title optimize: add prefix to no-format log print function when use system logger fix: add prefix to no-format log print function when use system logger Nov 11, 2022
@li-jin-gou li-jin-gou merged commit 201664a into cloudwego:develop Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants