Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: automatically skip when there is a label except invalid issue #490

Merged
merged 1 commit into from
Dec 26, 2022

Conversation

L2ncE
Copy link
Member

@L2ncE L2ncE commented Dec 26, 2022

What type of PR is this?

ci

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

当 issue 已经设置好标签时,ci 自动豁免,除了 invalid issue 标签。

(Optional) More detail description for this PR(en: English/zh: Chinese).

en:
When we don't want to use the ci that automatically increases the label in some cases, we can judge by whether there is a label. When there is a label that is not the invalid issue, ci will be skipped.

zh(optional):
在某些情况下我们不想使用自动增加标签的 ci 时,可以通过是否有标签来判断。当有标签不是 invalid issue 时,将跳过 ci。

Reference: https://stackoverflow.com/questions/63637826/how-to-check-if-an-issue-has-no-labels-in-a-github-workflow

Which issue(s) this PR fixes:

@L2ncE L2ncE requested review from a team as code owners December 26, 2022 03:14
@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Base: 69.69% // Head: 69.68% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (95715ae) compared to base (a7a3fc0).
Patch coverage: 78.57% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #490      +/-   ##
===========================================
- Coverage    69.69%   69.68%   -0.01%     
===========================================
  Files           93       93              
  Lines         8760     8774      +14     
===========================================
+ Hits          6105     6114       +9     
- Misses        2293     2296       +3     
- Partials       362      364       +2     
Impacted Files Coverage Δ
pkg/app/client/option.go 96.51% <78.57%> (-3.49%) ⬇️
pkg/app/client/client.go 73.41% <0.00%> (-1.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jin-gou
Copy link
Member

LGTM

@li-jin-gou li-jin-gou merged commit ebdd2f7 into cloudwego:develop Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants