Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize(hz): optimize the use experience for hz client #605

Merged
merged 7 commits into from
Feb 21, 2023

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Feb 10, 2023

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: optimize the use experience for hz client
zh(optional): 根据最近的反馈优化 hz client 的使用体验

Which issue(s) this PR fixes:

  • int value to string automatically
  • configuration of the default client
  • more concise client generation path (used as SDK)
  • "GET" requests add parameters to the query by default (when there is no tag)
  • use "GetName" for thrift

@FGYFFFF FGYFFFF requested review from a team as code owners February 10, 2023 08:38
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 72.07% // Head: 72.07% // No change to project coverage 👍

Coverage data is based on head (baffa29) compared to base (6b1ebb4).
Patch has no changes to coverable lines.

❗ Current head baffa29 differs from pull request most recent head 99a4bb1. Consider uploading reports for the commit 99a4bb1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #605   +/-   ##
========================================
  Coverage    72.07%   72.07%           
========================================
  Files           96       96           
  Lines         9389     9389           
========================================
  Hits          6767     6767           
  Misses        2189     2189           
  Partials       433      433           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FGYFFFF FGYFFFF changed the title [WIP]optimize(hz): optimize the use experience for hz client optimize(hz): optimize the use experience for hz client Feb 10, 2023
@FGYFFFF FGYFFFF force-pushed the optimize/hz_client_usage branch 2 times, most recently from d194b00 to d67b6ab Compare February 15, 2023 07:11
@FGYFFFF
Copy link
Contributor Author

FGYFFFF commented Feb 16, 2023

cmd/hz/app/app.go Outdated Show resolved Hide resolved
Duslia
Duslia previously approved these changes Feb 20, 2023
@FGYFFFF FGYFFFF force-pushed the optimize/hz_client_usage branch 2 times, most recently from b24376c to 8e7afbf Compare February 20, 2023 11:32
Duslia
Duslia previously approved these changes Feb 20, 2023
@FGYFFFF FGYFFFF merged commit 59ae2bd into cloudwego:develop Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants