-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test for pkg common test #669
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #669 +/- ##
===========================================
+ Coverage 72.49% 74.27% +1.77%
===========================================
Files 96 96
Lines 9392 9392
===========================================
+ Hits 6809 6976 +167
+ Misses 2154 1986 -168
- Partials 429 430 +1 see 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Please add ut coverage changes in PR's description🙏 |
Also you may check other PRs for how to fill the |
I changed them, but I'm not sure if the coverage is correct. |
OK |
@a631807682 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx~
Please check the PR description before merging.
What type of PR is this?
test
Check the PR title.
(Optional) Translate the PR title into Chinese.
添加
pkg/common/test
单测(Optional) More detail description for this PR(en: English/zh: Chinese).
en: Supplement unit test for
pkg/common/test
, coverage increased from 2.91% to 98.1%zh(optional): 补充
pkg/common/test
的单元测试,覆盖率从2.91%提高到了98.1%Which issue(s) this PR fixes:
related to #257