Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for pkg common test #669

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

a631807682
Copy link
Member

@a631807682 a631807682 commented Mar 15, 2023

What type of PR is this?

test

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

添加pkg/common/test单测

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: Supplement unit test for pkg/common/test, coverage increased from 2.91% to 98.1%
zh(optional): 补充pkg/common/test的单元测试,覆盖率从2.91%提高到了98.1%

Which issue(s) this PR fixes:

related to #257

@a631807682 a631807682 requested review from a team as code owners March 15, 2023 06:20
@li-jin-gou li-jin-gou self-assigned this Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.77 🎉

Comparison is base (c98aec7) 72.49% compared to head (d4d2a26) 74.27%.

❗ Current head d4d2a26 differs from pull request most recent head 649da1d. Consider uploading reports for the commit 649da1d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #669      +/-   ##
===========================================
+ Coverage    72.49%   74.27%   +1.77%     
===========================================
  Files           96       96              
  Lines         9392     9392              
===========================================
+ Hits          6809     6976     +167     
+ Misses        2154     1986     -168     
- Partials       429      430       +1     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jin-gou li-jin-gou added the enhancement New feature or request label Mar 15, 2023
@welkeyever
Copy link
Member

Please add ut coverage changes in PR's description🙏

@welkeyever
Copy link
Member

Also you may check other PRs for how to fill the What type of PR is this?.

@a631807682
Copy link
Member Author

Also you may check other PRs for how to fill the What type of PR is this?.

I changed them, but I'm not sure if the coverage is correct.

@li-jin-gou
Copy link
Member

Also you may check other PRs for how to fill the What type of PR is this?.

I changed them, but I'm not sure if the coverage is correct.

OK

@welkeyever
Copy link
Member

Also you may check other PRs for how to fill the What type of PR is this?.

I changed them, but I'm not sure if the coverage is correct.

@a631807682 What type of PR is this? section only needs the type which is test in you case🙏

Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx~
Please check the PR description before merging.

@welkeyever welkeyever merged commit 5f0145e into cloudwego:develop Mar 22, 2023
@a631807682 a631807682 deleted the ut_common_test branch March 22, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

5 participants