-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test for pkg/app #863
Conversation
Better add some info - including the coverage changes - in the description of PR. |
done |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #863 +/- ##
===========================================
+ Coverage 80.30% 81.97% +1.67%
===========================================
Files 97 97
Lines 9602 9604 +2
===========================================
+ Hits 7711 7873 +162
+ Misses 1408 1258 -150
+ Partials 483 473 -10
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx~
What type of PR is this?
test
Check the PR title.
<type>(optional scope): <description>
.(Optional) Translate the PR title into Chinese.
提升pkg/app的单元测试覆盖率
(Optional) More detail description for this PR(en: English/zh: Chinese).
en:Supplement unit test for pkg/app from 70.87% to 84.8%
zh(optional):提升pkg/app的单元测试覆盖率70.87%到84.8%
(Optional) Which issue(s) this PR fixes:
part of #257
(Optional) The PR that updates user documentation: