Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for protocol header #869

Merged
merged 5 commits into from Aug 23, 2023

Conversation

ViolaPioggia
Copy link
Member

@ViolaPioggia ViolaPioggia commented Jul 23, 2023

What type of PR is this?

test

(Optional) Translate the PR title into Chinese.

增加 pkg/protocol/header.go的单测覆盖率 到 90%

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: Increase the single test coverage of 'pkg/protocol/header. go' to 90%
zh(optional): 增加 pkg/protocol/header.go的单测覆盖率 到 90%

(Optional) Which issue(s) this PR fixes:

part of #257

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.20% 🎉

Comparison is base (61573bd) 79.87% compared to head (f53a541) 80.07%.

❗ Current head f53a541 differs from pull request most recent head b805ca8. Consider uploading reports for the commit b805ca8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #869      +/-   ##
===========================================
+ Coverage    79.87%   80.07%   +0.20%     
===========================================
  Files           97       97              
  Lines         9598     9598              
===========================================
+ Hits          7666     7686      +20     
+ Misses        1432     1421      -11     
+ Partials       500      491       -9     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx~

@welkeyever welkeyever merged commit 9e79d79 into cloudwego:develop Aug 23, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants