Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hz): hz tool don't gen sh in windows #942

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

chaoranz758
Copy link
Member

@chaoranz758 chaoranz758 commented Sep 9, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: hz tool don't gen sh in windows
zh(optional): windows 系统下 hz 工具不生成 build.sh 以及 script/bootstrap.sh

(Optional) Which issue(s) this PR fixes:

cloudwego/cloudwego.github.io#765

(Optional) The PR that updates user documentation:

@chaoranz758 chaoranz758 requested review from a team as code owners September 9, 2023 13:54
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05% 🎉

Comparison is base (03376c9) 81.95% compared to head (874aad1) 82.00%.

❗ Current head 874aad1 differs from pull request most recent head 6705bc1. Consider uploading reports for the commit 6705bc1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #942      +/-   ##
===========================================
+ Coverage    81.95%   82.00%   +0.05%     
===========================================
  Files           97       97              
  Lines         9625     9625              
===========================================
+ Hits          7888     7893       +5     
+ Misses        1263     1259       -4     
+ Partials       474      473       -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FGYFFFF FGYFFFF changed the title feat: hz tool don't gen sh in windows feat(hz): hz tool don't gen sh in windows Sep 12, 2023
@welkeyever
Copy link
Member

PR 描述参考其他的完善一下吧,type 是必填项 @chaoranz758

@welkeyever welkeyever merged commit 025f404 into cloudwego:develop Sep 19, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants