Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve hertz/pkg/routeut unit test coverage #992

Merged
merged 8 commits into from Nov 26, 2023

Conversation

HzTTT
Copy link
Contributor

@HzTTT HzTTT commented Nov 10, 2023

What type of PR is this?

test

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

提高 Hertz/pkg/routeut 单元测试覆盖率

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:hertz/pkg/routeut unit test coverage increased from 78.49% to 85.1%
zh(optional):hertz/pkg/routeut 单元测试覆盖率从 78.49% 增加到 85.1%

(Optional) Which issue(s) this PR fixes:

Part of #257

(Optional) The PR that updates user documentation:

@HzTTT HzTTT requested review from a team as code owners November 10, 2023 18:10
@CLAassistant
Copy link

CLAassistant commented Nov 10, 2023

CLA assistant check
All committers have signed the CLA.

@li-jin-gou
Copy link
Member

@HzTTT 修复一下 CI

@li-jin-gou
Copy link
Member

本地安装 gofumpt 执行 gofumpt -e -d -w -extra . 可以修复一下 CI

@HzTTT
Copy link
Contributor Author

HzTTT commented Nov 21, 2023

@li-jin-gou
ok

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c3f0b7) 81.81% compared to head (0c412a7) 82.52%.

❗ Current head 0c412a7 differs from pull request most recent head 3cb2f6f. Consider uploading reports for the commit 3cb2f6f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #992      +/-   ##
===========================================
+ Coverage    81.81%   82.52%   +0.71%     
===========================================
  Files           98       98              
  Lines         9962     9962              
===========================================
+ Hits          8150     8221      +71     
+ Misses        1319     1244      -75     
- Partials       493      497       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx~

@li-jin-gou li-jin-gou merged commit 89e9721 into cloudwego:develop Nov 26, 2023
10 of 14 checks passed
@HzTTT HzTTT deleted the test branch November 28, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants