fix(netpollmux): fix a bug that disables multi-service by assigning the first svcInfo to targetSvcInfo #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marina-Sakai
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1294 +/- ##
===========================================
+ Coverage 70.20% 70.27% +0.07%
===========================================
Files 290 290
Lines 20902 20901 -1
===========================================
+ Hits 14674 14689 +15
+ Misses 5021 5011 -10
+ Partials 1207 1201 -6 ☔ View full report in Codecov by Sentry. |
Marina-Sakai
changed the title
Marina-Sakai
force-pushed
the
fix/multi_service_with_netpollmux
branch
from
9628106
to
2a0b7bd
Compare
Marina-Sakai
force-pushed
the
fix/multi_service_with_netpollmux
branch
from
2a0b7bd
to
f72ec3a
Compare
felix021
approved these changes
Mar 21, 2024
|
This PR is the fix for #1285 |
jayantxie
approved these changes
Mar 22, 2024
DMwangnima
pushed a commit
to DMwangnima/kitex
that referenced
this pull request
Apr 11, 2024
…he first svcInfo to targetSvcInfo (cloudwego#1294)
joway
pushed a commit
that referenced
this pull request
Apr 11, 2024
…he first svcInfo to targetSvcInfo (#1294)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: