fix(payloadCodec): replace the registered PayloadCodec if the type is same when using WithPayloadCodec for server-side #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng WithPayloadCodec
YangruiEmma
changed the title
…ng WithPayloadCodec
jayantxie
approved these changes
May 28, 2024
Marina-Sakai
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(Optional) Translate the PR title into Chinese.
fix: 使用 WithPayloadCodec 设置的 PayloadCodec 如果是预注册的，则替换预注册的PayloadCodec
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional): WithPayloadCodec 设置 PayloadCodec 后，会限定Server所有请求都用该 PayloadCodec，但如果设置的是预注册的PayloadCodec类型，是为了对预注册的PayloadCodec添加额外的配置，只需替换掉注册的 PayloadCodec。
如果不做此修改，在多 Service 场景，假如用户设置了 NewThriftCodecWithConfig 就会导致 Protobuf 的请求无法被解码。
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: