fix: support setting PurePayload Transport Protocol #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMwangnima
force-pushed
the
online/setting_purepayload
branch
from
ced1835
to
4d5efb5
Compare
ppzqh
approved these changes
Jul 17, 2024
YangruiEmma
approved these changes
Jul 17, 2024
ShawnJeffersonWang
pushed a commit
to ShawnJeffersonWang/kitex
that referenced
this pull request
Jul 19, 2024
DMwangnima
added a commit
that referenced
this pull request
Jul 19, 2024
This reverts commit 6ca32e5.
3 tasks
ShawnJeffersonWang
added a commit
to ShawnJeffersonWang/kitex
that referenced
this pull request
Aug 7, 2024
Signed-off-by: shawn <xw2002121@gmail.com> fix: fix some issue Signed-off-by: shawn <xw2002121@gmail.com> perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) chore: remove useless reflection api (cloudwego#1433) optimize(lb): rebalance when instance weights updated (cloudwego#1397) fix: support setting PurePayload Transport Protocol (cloudwego#1436) # Conflicts: # internal/generic/thrift/http_fallback.go # pkg/protocol/bthrift/binary.go # pkg/rpcinfo/rpcconfig.go # pkg/rpcinfo/rpcconfig_test.go # tool/cmd/kitex/args/tpl_args.go # tool/cmd/kitex/main.go # tool/internal_pkg/generator/generator.go # tool/internal_pkg/pluginmode/thriftgo/plugin.go # tool/internal_pkg/util/command.go
ShawnJeffersonWang
added a commit
to ShawnJeffersonWang/kitex
that referenced
this pull request
Aug 7, 2024
Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix bug in generator_test Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: add gen-path Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: treat option as unknown command Signed-off-by: shawn <xw2002121@gmail.com> bug fix: fix unused code in command and flag Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix lint Signed-off-by: shawn <xw2002121@gmail.com> fix: use gofumpt -extra to fix golanci lint Signed-off-by: shawn <xw2002121@gmail.com> fix: use gofumpt to avoid golangci lint Signed-off-by: shawn <xw2002121@gmail.com> add InitType perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) chore: remove useless reflection api (cloudwego#1433) optimize(lb): rebalance when instance weights updated (cloudwego#1397) fix: support setting PurePayload Transport Protocol (cloudwego#1436) fix: fix a bug "unknown service xxx" when using CombineService client by not writing IDLServiceName and searching serviceInfo by method name (cloudwego#1402) fix: support setting PurePayload with new style (cloudwego#1438) refactor(multi-services): refactoring service and method routing for multi-services (cloudwego#1439) refactor: move apache code to separated pkg (cloudwego#1381) Co-authored-by: QihengZhou <qiheng.zhou@bytedance.com> Co-authored-by: Yi Duan <duanyi.aster@bytedance.com> refactor(generic): refactor existing generic to have new ServiceInfo which has the generic's reader and writer info directly (cloudwego#1408) chore: upgrade go directive version to 1.17 of go.mod (cloudwego#1415) refactor: get rid of apache TApplicationException (cloudwego#1389) feat(generic): support grpc json generic for client (cloudwego#1411) feat: add PrependError for thriftgo (cloudwego#1420) feat(thrift): generic fastcodec (cloudwego#1424) feat(tool): no apache for fastcodec (cloudwego#1426) * use bthrift.PrependError * updated kitex tool MinDepVersion to 0.11.0 * fixed `undefined: bthrift.KitexUnusedProtection` chore: fixed undefined KitexUnusedProtection (cloudwego#1428) test: works without apache code (cloudwego#1429) chore: update CI version and readme community (cloudwego#1431) refactor: new generic interface without thrift apache (cloudwego#1434) fix(generic): fix payload length check for http generic (cloudwego#1442) chore: pick and fix conflict commits from develop branch (cloudwego#1457) Co-authored-by: Jayant <xiezhengyao@bytedance.com> chore: update dependency (cloudwego#1447) chore(ci): disable cache for lint and staticchecks (cloudwego#1451) refactor(test): perf optimize and log loc correct (cloudwego#1455) chore(ci): speed up multiple ci processes 8min -> 1min (cloudwego#1454) * rm unused codeconv, it didn't work as expected due to quota and user experience * don't use cache for self-hosted runners * cache for github hosted runners hotfix: multi service registry issue chore(ci): optimized bench tests. it takes <1m now (cloudwego#1461) chore(test): fix xorshift64 in consist_test.go (cloudwego#1462) chore: fix grpc keepalive test by start server responsiblly (cloudwego#1463) refactor: deprecate bthrift, use cloudwego/gopkg (cloudwego#1441) * tool: generates code for using cloudwego/gopkg * internal/mocks: updated thrift using the latest tool * pkg/utils/fastthrift: moved to cloudwego/gopkg * pkg/remote/codec/thrift: uses skipdecoder of cloudwego/gopkg * pkg/remote/codec/thrift: add fastcodec as a fallback, and always use fastcodec for Ex * pkg/generic: uses cloudwego/gopkg for pkg/protocol/bthrift: * type BinaryWriter = gopkgthrift.NocopyWriter * Removed ThriftFastCodec, moved to cloudwego/gopkg before releasing * Removed bthrift/exception.go, moved to cloudwego/gopkg before releasing * Removed bthrift/test, only for unknownfields testing * bthrift/unknown: moved to cloudwego/gopkg refactor(generic): remove apache thrift.TProtocol from generic (cloudwego#1450)
ShawnJeffersonWang
pushed a commit
to ShawnJeffersonWang/kitex
that referenced
this pull request
Aug 7, 2024
ShawnJeffersonWang
added a commit
to ShawnJeffersonWang/kitex
that referenced
this pull request
Aug 7, 2024
Signed-off-by: shawn <xw2002121@gmail.com> fix: fix some issue Signed-off-by: shawn <xw2002121@gmail.com> perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) chore: remove useless reflection api (cloudwego#1433) optimize(lb): rebalance when instance weights updated (cloudwego#1397) fix: support setting PurePayload Transport Protocol (cloudwego#1436) bug fixes: fix render Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix bug in generator_test Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: add gen-path Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: treat option as unknown command Signed-off-by: shawn <xw2002121@gmail.com> bug fix: fix unused code in command and flag Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix lint Signed-off-by: shawn <xw2002121@gmail.com> fix: use gofumpt -extra to fix golanci lint Signed-off-by: shawn <xw2002121@gmail.com> fix: use gofumpt to avoid golangci lint Signed-off-by: shawn <xw2002121@gmail.com> add InitType perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) chore: remove useless reflection api (cloudwego#1433) optimize(lb): rebalance when instance weights updated (cloudwego#1397) fix: support setting PurePayload Transport Protocol (cloudwego#1436) fix: fix a bug "unknown service xxx" when using CombineService client by not writing IDLServiceName and searching serviceInfo by method name (cloudwego#1402) fix: support setting PurePayload with new style (cloudwego#1438) refactor(multi-services): refactoring service and method routing for multi-services (cloudwego#1439) refactor: move apache code to separated pkg (cloudwego#1381) Co-authored-by: QihengZhou <qiheng.zhou@bytedance.com> Co-authored-by: Yi Duan <duanyi.aster@bytedance.com> refactor(generic): refactor existing generic to have new ServiceInfo which has the generic's reader and writer info directly (cloudwego#1408) chore: upgrade go directive version to 1.17 of go.mod (cloudwego#1415) refactor: get rid of apache TApplicationException (cloudwego#1389) feat(generic): support grpc json generic for client (cloudwego#1411) feat: add PrependError for thriftgo (cloudwego#1420) feat(thrift): generic fastcodec (cloudwego#1424) feat(tool): no apache for fastcodec (cloudwego#1426) * use bthrift.PrependError * updated kitex tool MinDepVersion to 0.11.0 * fixed `undefined: bthrift.KitexUnusedProtection` chore: fixed undefined KitexUnusedProtection (cloudwego#1428) test: works without apache code (cloudwego#1429) chore: update CI version and readme community (cloudwego#1431) refactor: new generic interface without thrift apache (cloudwego#1434) fix(generic): fix payload length check for http generic (cloudwego#1442) chore: pick and fix conflict commits from develop branch (cloudwego#1457) Co-authored-by: Jayant <xiezhengyao@bytedance.com> chore: update dependency (cloudwego#1447) chore(ci): disable cache for lint and staticchecks (cloudwego#1451) refactor(test): perf optimize and log loc correct (cloudwego#1455) chore(ci): speed up multiple ci processes 8min -> 1min (cloudwego#1454) * rm unused codeconv, it didn't work as expected due to quota and user experience * don't use cache for self-hosted runners * cache for github hosted runners hotfix: multi service registry issue chore(ci): optimized bench tests. it takes <1m now (cloudwego#1461) chore(test): fix xorshift64 in consist_test.go (cloudwego#1462) chore: fix grpc keepalive test by start server responsiblly (cloudwego#1463) refactor: deprecate bthrift, use cloudwego/gopkg (cloudwego#1441) * tool: generates code for using cloudwego/gopkg * internal/mocks: updated thrift using the latest tool * pkg/utils/fastthrift: moved to cloudwego/gopkg * pkg/remote/codec/thrift: uses skipdecoder of cloudwego/gopkg * pkg/remote/codec/thrift: add fastcodec as a fallback, and always use fastcodec for Ex * pkg/generic: uses cloudwego/gopkg for pkg/protocol/bthrift: * type BinaryWriter = gopkgthrift.NocopyWriter * Removed ThriftFastCodec, moved to cloudwego/gopkg before releasing * Removed bthrift/exception.go, moved to cloudwego/gopkg before releasing * Removed bthrift/test, only for unknownfields testing * bthrift/unknown: moved to cloudwego/gopkg refactor(generic): remove apache thrift.TProtocol from generic (cloudwego#1450) add test for command and flag add test for command and flag resolve conflicts refactor: rm apache thrift in pkg/generic & netpollmux (cloudwego#1470) fix: allow HEADERS frame with empty header block fragment (cloudwego#1466) refactor: rm apache thrift in internal/mocks (cloudwego#1474) also: fix(server): invoker return err if no apache codec fix(server): listening on loopback addr chore: remove github.com/stretchr/testify direct dependency (cloudwego#1475) chore: upgrade gopkg to v0.1.0 (cloudwego#1477) perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) resolve conflicts feat: add init Signed-off-by: shawn <xw2002121@gmail.com> feat: render with multiple files and debug mode Signed-off-by: shawn <xw2002121@gmail.com> feat: add subcommand clean Signed-off-by: shawn <xw2002121@gmail.com> feat: add kitex_render_meta.yaml for render Signed-off-by: shawn <xw2002121@gmail.com> feat: add remote repo for render and middlewares Signed-off-by: shawn <xw2002121@gmail.com> chore(generic): add generic base using gopkg base (cloudwego#1482) fix(gonet): adjust gonet server read timeout to avoid read error (cloudwego#1481) fix: remove redundant line Signed-off-by: shawn <xw2002121@gmail.com> fix: fix single command Signed-off-by: shawn <xw2002121@gmail.com> feat: add userDefinedMiddleware Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix render Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix bug in generator_test Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: add gen-path Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: treat option as unknown command Signed-off-by: shawn <xw2002121@gmail.com> bug fix: fix unused code in command and flag Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix lint Signed-off-by: shawn <xw2002121@gmail.com> fix: use gofumpt -extra to fix golanci lint Signed-off-by: shawn <xw2002121@gmail.com> fix: use gofumpt to avoid golangci lint Signed-off-by: shawn <xw2002121@gmail.com> add InitType perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) optimize(lb): rebalance when instance weights updated (cloudwego#1397) fix: support setting PurePayload with new style (cloudwego#1438) refactor: move apache code to separated pkg (cloudwego#1381) Co-authored-by: QihengZhou <qiheng.zhou@bytedance.com> Co-authored-by: Yi Duan <duanyi.aster@bytedance.com> refactor: get rid of apache TApplicationException (cloudwego#1389) feat: add PrependError for thriftgo (cloudwego#1420) feat(thrift): generic fastcodec (cloudwego#1424) feat(tool): no apache for fastcodec (cloudwego#1426) * use bthrift.PrependError * updated kitex tool MinDepVersion to 0.11.0 * fixed `undefined: bthrift.KitexUnusedProtection` chore: fixed undefined KitexUnusedProtection (cloudwego#1428) chore: pick and fix conflict commits from develop branch (cloudwego#1457) Co-authored-by: Jayant <xiezhengyao@bytedance.com> chore: update dependency (cloudwego#1447) chore(ci): disable cache for lint and staticchecks (cloudwego#1451) refactor(test): perf optimize and log loc correct (cloudwego#1455) hotfix: multi service registry issue chore: update version v0.10.3 chore(test): fix xorshift64 in consist_test.go (cloudwego#1462) chore: fix grpc keepalive test by start server responsiblly (cloudwego#1463) refactor: deprecate bthrift, use cloudwego/gopkg (cloudwego#1441) * tool: generates code for using cloudwego/gopkg * internal/mocks: updated thrift using the latest tool * pkg/utils/fastthrift: moved to cloudwego/gopkg * pkg/remote/codec/thrift: uses skipdecoder of cloudwego/gopkg * pkg/remote/codec/thrift: add fastcodec as a fallback, and always use fastcodec for Ex * pkg/generic: uses cloudwego/gopkg for pkg/protocol/bthrift: * type BinaryWriter = gopkgthrift.NocopyWriter * Removed ThriftFastCodec, moved to cloudwego/gopkg before releasing * Removed bthrift/exception.go, moved to cloudwego/gopkg before releasing * Removed bthrift/test, only for unknownfields testing * bthrift/unknown: moved to cloudwego/gopkg refactor(generic): remove apache thrift.TProtocol from generic (cloudwego#1450) add test for command and flag add test for command and flag resolve conflicts refactor: rm apache thrift in pkg/generic & netpollmux (cloudwego#1470) fix: allow HEADERS frame with empty header block fragment (cloudwego#1466) refactor: rm apache thrift in internal/mocks (cloudwego#1474) also: fix(server): invoker return err if no apache codec fix(server): listening on loopback addr chore: remove github.com/stretchr/testify direct dependency (cloudwego#1475) chore: upgrade gopkg to v0.1.0 (cloudwego#1477) perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) resolve conflicts feat: add init Signed-off-by: shawn <xw2002121@gmail.com>
ShawnJeffersonWang
added a commit
to ShawnJeffersonWang/kitex
that referenced
this pull request
Aug 7, 2024
Signed-off-by: shawn <xw2002121@gmail.com> feat: add subcommand clean Signed-off-by: shawn <xw2002121@gmail.com> refactor: rm apache thrift in internal/mocks (cloudwego#1474) also: fix(server): invoker return err if no apache codec fix(server): listening on loopback addr chore: remove github.com/stretchr/testify direct dependency (cloudwego#1475) chore: upgrade gopkg to v0.1.0 (cloudwego#1477) feat: add kitex_render_meta.yaml for render Signed-off-by: shawn <xw2002121@gmail.com> feat: add remote repo for render and middlewares Signed-off-by: shawn <xw2002121@gmail.com> chore(generic): add generic base using gopkg base (cloudwego#1482) fix(gonet): adjust gonet server read timeout to avoid read error (cloudwego#1481) fix: remove redundant line Signed-off-by: shawn <xw2002121@gmail.com> fix: fix single command Signed-off-by: shawn <xw2002121@gmail.com> refactor: use github.com/cloudwego/gopkg/protocol/thrift/apache (cloudwego#1483) * added README.md for pkg/protocol/bthrift * pkg/protocol/bthrift: not import kitex other pkgs * pkg/protocol/bthrift/apache: clear up -> thrift.go * pkg/generic: no apache codec * pkg/remote/codec/thrift: deprecate BinaryProtocol * pkg/utils: deprecate apache codec * tool: add `thrift_import_path` by default feat: add template render subcommand using .tpl Signed-off-by: shawn <xw2002121@gmail.com> fix: fix some issue Signed-off-by: shawn <xw2002121@gmail.com> perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) chore: remove useless reflection api (cloudwego#1433) optimize(lb): rebalance when instance weights updated (cloudwego#1397) fix: support setting PurePayload Transport Protocol (cloudwego#1436) bug fixes: fix render Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix bug in generator_test Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: add gen-path Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: treat option as unknown command Signed-off-by: shawn <xw2002121@gmail.com> bug fix: fix unused code in command and flag Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix lint Signed-off-by: shawn <xw2002121@gmail.com> fix: use gofumpt -extra to fix golanci lint Signed-off-by: shawn <xw2002121@gmail.com> fix: use gofumpt to avoid golangci lint Signed-off-by: shawn <xw2002121@gmail.com> add InitType perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) chore: remove useless reflection api (cloudwego#1433) optimize(lb): rebalance when instance weights updated (cloudwego#1397) fix: support setting PurePayload Transport Protocol (cloudwego#1436) fix: fix a bug "unknown service xxx" when using CombineService client by not writing IDLServiceName and searching serviceInfo by method name (cloudwego#1402) fix: support setting PurePayload with new style (cloudwego#1438) refactor(multi-services): refactoring service and method routing for multi-services (cloudwego#1439) refactor: move apache code to separated pkg (cloudwego#1381) Co-authored-by: QihengZhou <qiheng.zhou@bytedance.com> Co-authored-by: Yi Duan <duanyi.aster@bytedance.com> refactor(generic): refactor existing generic to have new ServiceInfo which has the generic's reader and writer info directly (cloudwego#1408) chore: upgrade go directive version to 1.17 of go.mod (cloudwego#1415) refactor: get rid of apache TApplicationException (cloudwego#1389) feat(generic): support grpc json generic for client (cloudwego#1411) feat: add PrependError for thriftgo (cloudwego#1420) feat(thrift): generic fastcodec (cloudwego#1424) feat(tool): no apache for fastcodec (cloudwego#1426) * use bthrift.PrependError * updated kitex tool MinDepVersion to 0.11.0 * fixed `undefined: bthrift.KitexUnusedProtection` chore: fixed undefined KitexUnusedProtection (cloudwego#1428) test: works without apache code (cloudwego#1429) chore: update CI version and readme community (cloudwego#1431) refactor: new generic interface without thrift apache (cloudwego#1434) fix(generic): fix payload length check for http generic (cloudwego#1442) chore: pick and fix conflict commits from develop branch (cloudwego#1457) Co-authored-by: Jayant <xiezhengyao@bytedance.com> chore: update dependency (cloudwego#1447) chore(ci): disable cache for lint and staticchecks (cloudwego#1451) refactor(test): perf optimize and log loc correct (cloudwego#1455) chore(ci): speed up multiple ci processes 8min -> 1min (cloudwego#1454) * rm unused codeconv, it didn't work as expected due to quota and user experience * don't use cache for self-hosted runners * cache for github hosted runners hotfix: multi service registry issue chore(ci): optimized bench tests. it takes <1m now (cloudwego#1461) chore(test): fix xorshift64 in consist_test.go (cloudwego#1462) chore: fix grpc keepalive test by start server responsiblly (cloudwego#1463) refactor: deprecate bthrift, use cloudwego/gopkg (cloudwego#1441) * tool: generates code for using cloudwego/gopkg * internal/mocks: updated thrift using the latest tool * pkg/utils/fastthrift: moved to cloudwego/gopkg * pkg/remote/codec/thrift: uses skipdecoder of cloudwego/gopkg * pkg/remote/codec/thrift: add fastcodec as a fallback, and always use fastcodec for Ex * pkg/generic: uses cloudwego/gopkg for pkg/protocol/bthrift: * type BinaryWriter = gopkgthrift.NocopyWriter * Removed ThriftFastCodec, moved to cloudwego/gopkg before releasing * Removed bthrift/exception.go, moved to cloudwego/gopkg before releasing * Removed bthrift/test, only for unknownfields testing * bthrift/unknown: moved to cloudwego/gopkg refactor(generic): remove apache thrift.TProtocol from generic (cloudwego#1450) add test for command and flag add test for command and flag resolve conflicts refactor: rm apache thrift in pkg/generic & netpollmux (cloudwego#1470) fix: allow HEADERS frame with empty header block fragment (cloudwego#1466) refactor: rm apache thrift in internal/mocks (cloudwego#1474) also: fix(server): invoker return err if no apache codec fix(server): listening on loopback addr chore: remove github.com/stretchr/testify direct dependency (cloudwego#1475) chore: upgrade gopkg to v0.1.0 (cloudwego#1477) perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) resolve conflicts feat: add init Signed-off-by: shawn <xw2002121@gmail.com> feat: render with multiple files and debug mode Signed-off-by: shawn <xw2002121@gmail.com> feat: add subcommand clean Signed-off-by: shawn <xw2002121@gmail.com> feat: add kitex_render_meta.yaml for render Signed-off-by: shawn <xw2002121@gmail.com> feat: add remote repo for render and middlewares Signed-off-by: shawn <xw2002121@gmail.com> chore(generic): add generic base using gopkg base (cloudwego#1482) fix(gonet): adjust gonet server read timeout to avoid read error (cloudwego#1481) fix: remove redundant line Signed-off-by: shawn <xw2002121@gmail.com> fix: fix single command Signed-off-by: shawn <xw2002121@gmail.com> feat: add userDefinedMiddleware Signed-off-by: shawn <xw2002121@gmail.com> feat: add middleware Signed-off-by: shawn <xw2002121@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
fix: 支持设置 PurePayload Transport Protocol。
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
Currently, using or setting the transport protocol directly does not work for PurePayload.
zh(optional):
当前，直接使用或运算设置 transport protocol 对 PurePayload 不生效
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: