feat(generic): support grpc json generic for client #1411

Marina-Sakai · 2024-06-24T05:44:15Z

What type of PR is this?

Check the PR title.

This PR title match the format: <type>(optional scope): <description>
The description of this PR title is user-oriented and clear enough for others to understand.
Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

codecov · 2024-06-24T05:51:36Z

Codecov Report

Attention: Patch coverage is 31.92982% with 194 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-v0.11.0@63e6412). Learn more about missing BASE report.

❗ Current head b84656f differs from pull request most recent head 71f22c8

Please upload reports for the commit 71f22c8 to get more accurate results.

Files	Patch %	Lines
client/genericclient/stream.go	0.00%	107 Missing ⚠️
server/genericserver/stream.go	0.00%	28 Missing ⚠️
pkg/generic/generic_stream_service.go	0.00%	24 Missing ⚠️
pkg/generic/grpcjsonpb_test/generic_init.go	78.20%	10 Missing and 7 partials ⚠️
pkg/remote/codec/grpc/grpc.go	0.00%	15 Missing ⚠️
pkg/generic/thrift/parse.go	86.66%	1 Missing and 1 partial ⚠️
pkg/generic/httppbthrift_codec.go	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                Coverage Diff                 @@
##             release-v0.11.0    #1411   +/-   ##
==================================================
  Coverage                   ?   69.75%           
==================================================
  Files                      ?      300           
  Lines                      ?    21505           
  Branches                   ?        0           
==================================================
  Hits                       ?    15000           
  Misses                     ?     5274           
  Partials                   ?     1231

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/generic/generic_stream_service.go

jayantxie

LGTM

client/genericclient/stream.go

internal/mocks/proto/pbapi.proto

…which has the generic's reader and writer info directly (cloudwego#1365)

…s GenericService

client/genericclient/generic_stream_service.go

client/genericclient/stream.go

Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix bug in generator_test Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: add gen-path Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: treat option as unknown command Signed-off-by: shawn <xw2002121@gmail.com> bug fix: fix unused code in command and flag Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix lint Signed-off-by: shawn <xw2002121@gmail.com> fix: use gofumpt -extra to fix golanci lint Signed-off-by: shawn <xw2002121@gmail.com> fix: use gofumpt to avoid golangci lint Signed-off-by: shawn <xw2002121@gmail.com> add InitType perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) chore: remove useless reflection api (cloudwego#1433) optimize(lb): rebalance when instance weights updated (cloudwego#1397) fix: support setting PurePayload Transport Protocol (cloudwego#1436) fix: fix a bug "unknown service xxx" when using CombineService client by not writing IDLServiceName and searching serviceInfo by method name (cloudwego#1402) fix: support setting PurePayload with new style (cloudwego#1438) refactor(multi-services): refactoring service and method routing for multi-services (cloudwego#1439) refactor: move apache code to separated pkg (cloudwego#1381) Co-authored-by: QihengZhou <qiheng.zhou@bytedance.com> Co-authored-by: Yi Duan <duanyi.aster@bytedance.com> refactor(generic): refactor existing generic to have new ServiceInfo which has the generic's reader and writer info directly (cloudwego#1408) chore: upgrade go directive version to 1.17 of go.mod (cloudwego#1415) refactor: get rid of apache TApplicationException (cloudwego#1389) feat(generic): support grpc json generic for client (cloudwego#1411) feat: add PrependError for thriftgo (cloudwego#1420) feat(thrift): generic fastcodec (cloudwego#1424) feat(tool): no apache for fastcodec (cloudwego#1426) * use bthrift.PrependError * updated kitex tool MinDepVersion to 0.11.0 * fixed `undefined: bthrift.KitexUnusedProtection` chore: fixed undefined KitexUnusedProtection (cloudwego#1428) test: works without apache code (cloudwego#1429) chore: update CI version and readme community (cloudwego#1431) refactor: new generic interface without thrift apache (cloudwego#1434) fix(generic): fix payload length check for http generic (cloudwego#1442) chore: pick and fix conflict commits from develop branch (cloudwego#1457) Co-authored-by: Jayant <xiezhengyao@bytedance.com> chore: update dependency (cloudwego#1447) chore(ci): disable cache for lint and staticchecks (cloudwego#1451) refactor(test): perf optimize and log loc correct (cloudwego#1455) chore(ci): speed up multiple ci processes 8min -> 1min (cloudwego#1454) * rm unused codeconv, it didn't work as expected due to quota and user experience * don't use cache for self-hosted runners * cache for github hosted runners hotfix: multi service registry issue chore(ci): optimized bench tests. it takes <1m now (cloudwego#1461) chore(test): fix xorshift64 in consist_test.go (cloudwego#1462) chore: fix grpc keepalive test by start server responsiblly (cloudwego#1463) refactor: deprecate bthrift, use cloudwego/gopkg (cloudwego#1441) * tool: generates code for using cloudwego/gopkg * internal/mocks: updated thrift using the latest tool * pkg/utils/fastthrift: moved to cloudwego/gopkg * pkg/remote/codec/thrift: uses skipdecoder of cloudwego/gopkg * pkg/remote/codec/thrift: add fastcodec as a fallback, and always use fastcodec for Ex * pkg/generic: uses cloudwego/gopkg for pkg/protocol/bthrift: * type BinaryWriter = gopkgthrift.NocopyWriter * Removed ThriftFastCodec, moved to cloudwego/gopkg before releasing * Removed bthrift/exception.go, moved to cloudwego/gopkg before releasing * Removed bthrift/test, only for unknownfields testing * bthrift/unknown: moved to cloudwego/gopkg refactor(generic): remove apache thrift.TProtocol from generic (cloudwego#1450)

Signed-off-by: shawn <xw2002121@gmail.com> fix: fix some issue Signed-off-by: shawn <xw2002121@gmail.com> perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) chore: remove useless reflection api (cloudwego#1433) optimize(lb): rebalance when instance weights updated (cloudwego#1397) fix: support setting PurePayload Transport Protocol (cloudwego#1436) bug fixes: fix render Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix bug in generator_test Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: add gen-path Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: treat option as unknown command Signed-off-by: shawn <xw2002121@gmail.com> bug fix: fix unused code in command and flag Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix lint Signed-off-by: shawn <xw2002121@gmail.com> fix: use gofumpt -extra to fix golanci lint Signed-off-by: shawn <xw2002121@gmail.com> fix: use gofumpt to avoid golangci lint Signed-off-by: shawn <xw2002121@gmail.com> add InitType perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) chore: remove useless reflection api (cloudwego#1433) optimize(lb): rebalance when instance weights updated (cloudwego#1397) fix: support setting PurePayload Transport Protocol (cloudwego#1436) fix: fix a bug "unknown service xxx" when using CombineService client by not writing IDLServiceName and searching serviceInfo by method name (cloudwego#1402) fix: support setting PurePayload with new style (cloudwego#1438) refactor(multi-services): refactoring service and method routing for multi-services (cloudwego#1439) refactor: move apache code to separated pkg (cloudwego#1381) Co-authored-by: QihengZhou <qiheng.zhou@bytedance.com> Co-authored-by: Yi Duan <duanyi.aster@bytedance.com> refactor(generic): refactor existing generic to have new ServiceInfo which has the generic's reader and writer info directly (cloudwego#1408) chore: upgrade go directive version to 1.17 of go.mod (cloudwego#1415) refactor: get rid of apache TApplicationException (cloudwego#1389) feat(generic): support grpc json generic for client (cloudwego#1411) feat: add PrependError for thriftgo (cloudwego#1420) feat(thrift): generic fastcodec (cloudwego#1424) feat(tool): no apache for fastcodec (cloudwego#1426) * use bthrift.PrependError * updated kitex tool MinDepVersion to 0.11.0 * fixed `undefined: bthrift.KitexUnusedProtection` chore: fixed undefined KitexUnusedProtection (cloudwego#1428) test: works without apache code (cloudwego#1429) chore: update CI version and readme community (cloudwego#1431) refactor: new generic interface without thrift apache (cloudwego#1434) fix(generic): fix payload length check for http generic (cloudwego#1442) chore: pick and fix conflict commits from develop branch (cloudwego#1457) Co-authored-by: Jayant <xiezhengyao@bytedance.com> chore: update dependency (cloudwego#1447) chore(ci): disable cache for lint and staticchecks (cloudwego#1451) refactor(test): perf optimize and log loc correct (cloudwego#1455) chore(ci): speed up multiple ci processes 8min -> 1min (cloudwego#1454) * rm unused codeconv, it didn't work as expected due to quota and user experience * don't use cache for self-hosted runners * cache for github hosted runners hotfix: multi service registry issue chore(ci): optimized bench tests. it takes <1m now (cloudwego#1461) chore(test): fix xorshift64 in consist_test.go (cloudwego#1462) chore: fix grpc keepalive test by start server responsiblly (cloudwego#1463) refactor: deprecate bthrift, use cloudwego/gopkg (cloudwego#1441) * tool: generates code for using cloudwego/gopkg * internal/mocks: updated thrift using the latest tool * pkg/utils/fastthrift: moved to cloudwego/gopkg * pkg/remote/codec/thrift: uses skipdecoder of cloudwego/gopkg * pkg/remote/codec/thrift: add fastcodec as a fallback, and always use fastcodec for Ex * pkg/generic: uses cloudwego/gopkg for pkg/protocol/bthrift: * type BinaryWriter = gopkgthrift.NocopyWriter * Removed ThriftFastCodec, moved to cloudwego/gopkg before releasing * Removed bthrift/exception.go, moved to cloudwego/gopkg before releasing * Removed bthrift/test, only for unknownfields testing * bthrift/unknown: moved to cloudwego/gopkg refactor(generic): remove apache thrift.TProtocol from generic (cloudwego#1450) add test for command and flag add test for command and flag resolve conflicts refactor: rm apache thrift in pkg/generic & netpollmux (cloudwego#1470) fix: allow HEADERS frame with empty header block fragment (cloudwego#1466) refactor: rm apache thrift in internal/mocks (cloudwego#1474) also: fix(server): invoker return err if no apache codec fix(server): listening on loopback addr chore: remove github.com/stretchr/testify direct dependency (cloudwego#1475) chore: upgrade gopkg to v0.1.0 (cloudwego#1477) perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) resolve conflicts feat: add init Signed-off-by: shawn <xw2002121@gmail.com> feat: render with multiple files and debug mode Signed-off-by: shawn <xw2002121@gmail.com> feat: add subcommand clean Signed-off-by: shawn <xw2002121@gmail.com> feat: add kitex_render_meta.yaml for render Signed-off-by: shawn <xw2002121@gmail.com> feat: add remote repo for render and middlewares Signed-off-by: shawn <xw2002121@gmail.com> chore(generic): add generic base using gopkg base (cloudwego#1482) fix(gonet): adjust gonet server read timeout to avoid read error (cloudwego#1481) fix: remove redundant line Signed-off-by: shawn <xw2002121@gmail.com> fix: fix single command Signed-off-by: shawn <xw2002121@gmail.com> feat: add userDefinedMiddleware Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix render Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix bug in generator_test Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: add gen-path Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: treat option as unknown command Signed-off-by: shawn <xw2002121@gmail.com> bug fix: fix unused code in command and flag Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix lint Signed-off-by: shawn <xw2002121@gmail.com> fix: use gofumpt -extra to fix golanci lint Signed-off-by: shawn <xw2002121@gmail.com> fix: use gofumpt to avoid golangci lint Signed-off-by: shawn <xw2002121@gmail.com> add InitType perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) optimize(lb): rebalance when instance weights updated (cloudwego#1397) fix: support setting PurePayload with new style (cloudwego#1438) refactor: move apache code to separated pkg (cloudwego#1381) Co-authored-by: QihengZhou <qiheng.zhou@bytedance.com> Co-authored-by: Yi Duan <duanyi.aster@bytedance.com> refactor: get rid of apache TApplicationException (cloudwego#1389) feat: add PrependError for thriftgo (cloudwego#1420) feat(thrift): generic fastcodec (cloudwego#1424) feat(tool): no apache for fastcodec (cloudwego#1426) * use bthrift.PrependError * updated kitex tool MinDepVersion to 0.11.0 * fixed `undefined: bthrift.KitexUnusedProtection` chore: fixed undefined KitexUnusedProtection (cloudwego#1428) chore: pick and fix conflict commits from develop branch (cloudwego#1457) Co-authored-by: Jayant <xiezhengyao@bytedance.com> chore: update dependency (cloudwego#1447) chore(ci): disable cache for lint and staticchecks (cloudwego#1451) refactor(test): perf optimize and log loc correct (cloudwego#1455) hotfix: multi service registry issue chore: update version v0.10.3 chore(test): fix xorshift64 in consist_test.go (cloudwego#1462) chore: fix grpc keepalive test by start server responsiblly (cloudwego#1463) refactor: deprecate bthrift, use cloudwego/gopkg (cloudwego#1441) * tool: generates code for using cloudwego/gopkg * internal/mocks: updated thrift using the latest tool * pkg/utils/fastthrift: moved to cloudwego/gopkg * pkg/remote/codec/thrift: uses skipdecoder of cloudwego/gopkg * pkg/remote/codec/thrift: add fastcodec as a fallback, and always use fastcodec for Ex * pkg/generic: uses cloudwego/gopkg for pkg/protocol/bthrift: * type BinaryWriter = gopkgthrift.NocopyWriter * Removed ThriftFastCodec, moved to cloudwego/gopkg before releasing * Removed bthrift/exception.go, moved to cloudwego/gopkg before releasing * Removed bthrift/test, only for unknownfields testing * bthrift/unknown: moved to cloudwego/gopkg refactor(generic): remove apache thrift.TProtocol from generic (cloudwego#1450) add test for command and flag add test for command and flag resolve conflicts refactor: rm apache thrift in pkg/generic & netpollmux (cloudwego#1470) fix: allow HEADERS frame with empty header block fragment (cloudwego#1466) refactor: rm apache thrift in internal/mocks (cloudwego#1474) also: fix(server): invoker return err if no apache codec fix(server): listening on loopback addr chore: remove github.com/stretchr/testify direct dependency (cloudwego#1475) chore: upgrade gopkg to v0.1.0 (cloudwego#1477) perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) resolve conflicts feat: add init Signed-off-by: shawn <xw2002121@gmail.com>

Signed-off-by: shawn <xw2002121@gmail.com> feat: add subcommand clean Signed-off-by: shawn <xw2002121@gmail.com> refactor: rm apache thrift in internal/mocks (cloudwego#1474) also: fix(server): invoker return err if no apache codec fix(server): listening on loopback addr chore: remove github.com/stretchr/testify direct dependency (cloudwego#1475) chore: upgrade gopkg to v0.1.0 (cloudwego#1477) feat: add kitex_render_meta.yaml for render Signed-off-by: shawn <xw2002121@gmail.com> feat: add remote repo for render and middlewares Signed-off-by: shawn <xw2002121@gmail.com> chore(generic): add generic base using gopkg base (cloudwego#1482) fix(gonet): adjust gonet server read timeout to avoid read error (cloudwego#1481) fix: remove redundant line Signed-off-by: shawn <xw2002121@gmail.com> fix: fix single command Signed-off-by: shawn <xw2002121@gmail.com> refactor: use github.com/cloudwego/gopkg/protocol/thrift/apache (cloudwego#1483) * added README.md for pkg/protocol/bthrift * pkg/protocol/bthrift: not import kitex other pkgs * pkg/protocol/bthrift/apache: clear up -> thrift.go * pkg/generic: no apache codec * pkg/remote/codec/thrift: deprecate BinaryProtocol * pkg/utils: deprecate apache codec * tool: add `thrift_import_path` by default feat: add template render subcommand using .tpl Signed-off-by: shawn <xw2002121@gmail.com> fix: fix some issue Signed-off-by: shawn <xw2002121@gmail.com> perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) chore: remove useless reflection api (cloudwego#1433) optimize(lb): rebalance when instance weights updated (cloudwego#1397) fix: support setting PurePayload Transport Protocol (cloudwego#1436) bug fixes: fix render Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix bug in generator_test Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: add gen-path Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: treat option as unknown command Signed-off-by: shawn <xw2002121@gmail.com> bug fix: fix unused code in command and flag Signed-off-by: shawn <xw2002121@gmail.com> bug fixes: fix lint Signed-off-by: shawn <xw2002121@gmail.com> fix: use gofumpt -extra to fix golanci lint Signed-off-by: shawn <xw2002121@gmail.com> fix: use gofumpt to avoid golangci lint Signed-off-by: shawn <xw2002121@gmail.com> add InitType perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) chore: remove useless reflection api (cloudwego#1433) optimize(lb): rebalance when instance weights updated (cloudwego#1397) fix: support setting PurePayload Transport Protocol (cloudwego#1436) fix: fix a bug "unknown service xxx" when using CombineService client by not writing IDLServiceName and searching serviceInfo by method name (cloudwego#1402) fix: support setting PurePayload with new style (cloudwego#1438) refactor(multi-services): refactoring service and method routing for multi-services (cloudwego#1439) refactor: move apache code to separated pkg (cloudwego#1381) Co-authored-by: QihengZhou <qiheng.zhou@bytedance.com> Co-authored-by: Yi Duan <duanyi.aster@bytedance.com> refactor(generic): refactor existing generic to have new ServiceInfo which has the generic's reader and writer info directly (cloudwego#1408) chore: upgrade go directive version to 1.17 of go.mod (cloudwego#1415) refactor: get rid of apache TApplicationException (cloudwego#1389) feat(generic): support grpc json generic for client (cloudwego#1411) feat: add PrependError for thriftgo (cloudwego#1420) feat(thrift): generic fastcodec (cloudwego#1424) feat(tool): no apache for fastcodec (cloudwego#1426) * use bthrift.PrependError * updated kitex tool MinDepVersion to 0.11.0 * fixed `undefined: bthrift.KitexUnusedProtection` chore: fixed undefined KitexUnusedProtection (cloudwego#1428) test: works without apache code (cloudwego#1429) chore: update CI version and readme community (cloudwego#1431) refactor: new generic interface without thrift apache (cloudwego#1434) fix(generic): fix payload length check for http generic (cloudwego#1442) chore: pick and fix conflict commits from develop branch (cloudwego#1457) Co-authored-by: Jayant <xiezhengyao@bytedance.com> chore: update dependency (cloudwego#1447) chore(ci): disable cache for lint and staticchecks (cloudwego#1451) refactor(test): perf optimize and log loc correct (cloudwego#1455) chore(ci): speed up multiple ci processes 8min -> 1min (cloudwego#1454) * rm unused codeconv, it didn't work as expected due to quota and user experience * don't use cache for self-hosted runners * cache for github hosted runners hotfix: multi service registry issue chore(ci): optimized bench tests. it takes <1m now (cloudwego#1461) chore(test): fix xorshift64 in consist_test.go (cloudwego#1462) chore: fix grpc keepalive test by start server responsiblly (cloudwego#1463) refactor: deprecate bthrift, use cloudwego/gopkg (cloudwego#1441) * tool: generates code for using cloudwego/gopkg * internal/mocks: updated thrift using the latest tool * pkg/utils/fastthrift: moved to cloudwego/gopkg * pkg/remote/codec/thrift: uses skipdecoder of cloudwego/gopkg * pkg/remote/codec/thrift: add fastcodec as a fallback, and always use fastcodec for Ex * pkg/generic: uses cloudwego/gopkg for pkg/protocol/bthrift: * type BinaryWriter = gopkgthrift.NocopyWriter * Removed ThriftFastCodec, moved to cloudwego/gopkg before releasing * Removed bthrift/exception.go, moved to cloudwego/gopkg before releasing * Removed bthrift/test, only for unknownfields testing * bthrift/unknown: moved to cloudwego/gopkg refactor(generic): remove apache thrift.TProtocol from generic (cloudwego#1450) add test for command and flag add test for command and flag resolve conflicts refactor: rm apache thrift in pkg/generic & netpollmux (cloudwego#1470) fix: allow HEADERS frame with empty header block fragment (cloudwego#1466) refactor: rm apache thrift in internal/mocks (cloudwego#1474) also: fix(server): invoker return err if no apache codec fix(server): listening on loopback addr chore: remove github.com/stretchr/testify direct dependency (cloudwego#1475) chore: upgrade gopkg to v0.1.0 (cloudwego#1477) perf: custom allocator for fast codec ReadString/ReadBinary (cloudwego#1427) resolve conflicts feat: add init Signed-off-by: shawn <xw2002121@gmail.com> feat: render with multiple files and debug mode Signed-off-by: shawn <xw2002121@gmail.com> feat: add subcommand clean Signed-off-by: shawn <xw2002121@gmail.com> feat: add kitex_render_meta.yaml for render Signed-off-by: shawn <xw2002121@gmail.com> feat: add remote repo for render and middlewares Signed-off-by: shawn <xw2002121@gmail.com> chore(generic): add generic base using gopkg base (cloudwego#1482) fix(gonet): adjust gonet server read timeout to avoid read error (cloudwego#1481) fix: remove redundant line Signed-off-by: shawn <xw2002121@gmail.com> fix: fix single command Signed-off-by: shawn <xw2002121@gmail.com> feat: add userDefinedMiddleware Signed-off-by: shawn <xw2002121@gmail.com> feat: add middleware Signed-off-by: shawn <xw2002121@gmail.com>

Marina-Sakai requested review from a team as code owners June 24, 2024 05:44

Marina-Sakai commented Jun 24, 2024

View reviewed changes

pkg/generic/generic_stream_service.go Outdated Show resolved Hide resolved

Marina-Sakai force-pushed the feat/grpc_generic_for_client branch from 16a8829 to cbae570 Compare June 25, 2024 05:09

jayantxie previously approved these changes Jun 26, 2024

View reviewed changes

AsterDY reviewed Jul 1, 2024

View reviewed changes

client/genericclient/stream.go Outdated Show resolved Hide resolved

AsterDY reviewed Jul 1, 2024

View reviewed changes

client/genericclient/stream.go Show resolved Hide resolved

AsterDY reviewed Jul 1, 2024

View reviewed changes

internal/mocks/proto/pbapi.proto Outdated Show resolved Hide resolved

AsterDY assigned AsterDY and felix021 Jul 1, 2024

Marina-Sakai dismissed jayantxie’s stale review via 5cd2fff July 2, 2024 05:48

Marina-Sakai and others added 17 commits July 2, 2024 13:48

refactor(generic): refactor existing generic to have new ServiceInfo …

a7abf16

…which has the generic's reader and writer info directly (cloudwego#1365)

chore: delete unnecessary files

d6a9bb2

chore: delete unnecessary files

8e4ec65

json thrift generic refactor

639094e

json pb refactor

ac0bef8

add err handling

e33c8e2

test: add and fix tests

10818a8

fix: nit things

1b07fa0

fix: pass method and isClient to writer and reader

9cb88f5

fix: make a TODO for binary generic multi-service

7864974

fix: arguments

cd46ddf

fix: no need to check cause ttheader doesn't pass idlSvcName when it'…

eaf08d4

…s GenericService

fix: lint

5fbc28f

refactor: remove codecInfo from serviceInfo

318e475

test: add and fix tests

e508875

fix: no need to check cause ttheader doesn't pass idlSvcName when it'…

d57bd83

…s GenericService

json thrift generic refactor

605c65c

Marina-Sakai added 6 commits July 2, 2024 13:48

delete: unused file

5e5d4c0

fix: no dynamicgo descriptor

c30da46

chore: fix comments

f1fda7c

chore: modify comment

7adb60a

refactor: move stream service into genericclient

f4f5d87

optimize: separate methodInfo

71f22c8

Marina-Sakai force-pushed the feat/grpc_generic_for_client branch from 5cd2fff to 71f22c8 Compare July 2, 2024 05:49

jayantxie previously approved these changes Jul 2, 2024

View reviewed changes

AsterDY previously approved these changes Jul 2, 2024

View reviewed changes

felix021 reviewed Jul 2, 2024

View reviewed changes

client/genericclient/generic_stream_service.go Outdated Show resolved Hide resolved

felix021 reviewed Jul 2, 2024

View reviewed changes

client/genericclient/stream.go Show resolved Hide resolved

chore: panic when binary generic is passed

84d094d

Marina-Sakai dismissed stale reviews from AsterDY and jayantxie via 84d094d July 3, 2024 03:24

AsterDY approved these changes Jul 3, 2024

View reviewed changes

jayantxie approved these changes Jul 3, 2024

View reviewed changes

Marina-Sakai merged commit ba2e246 into cloudwego:release-v0.11.0 Jul 3, 2024
20 checks passed

Marina-Sakai deleted the feat/grpc_generic_for_client branch July 3, 2024 04:57

YangruiEmma pushed a commit that referenced this pull request Jul 22, 2024

feat(generic): support grpc json generic for client (#1411)

4c540f2

xiaost pushed a commit that referenced this pull request Jul 23, 2024

feat(generic): support grpc json generic for client (#1411)

908428b

xiaost pushed a commit that referenced this pull request Jul 23, 2024

feat(generic): support grpc json generic for client (#1411)

af00c6a

xiaost pushed a commit that referenced this pull request Jul 23, 2024

feat(generic): support grpc json generic for client (#1411)

8acf365

Marina-Sakai added a commit to Marina-Sakai/kitex that referenced this pull request Jul 25, 2024

feat(generic): support grpc json generic for client (cloudwego#1411)

56e4748

Marina-Sakai added a commit to Marina-Sakai/kitex that referenced this pull request Jul 25, 2024

feat(generic): support grpc json generic for client (cloudwego#1411)

c396e96

Marina-Sakai added a commit to Marina-Sakai/kitex that referenced this pull request Jul 26, 2024

feat(generic): support grpc json generic for client (cloudwego#1411)

49e83ae

Marina-Sakai added a commit that referenced this pull request Jul 31, 2024

feat(generic): support grpc json generic for client (#1411)

ba779ce

ShawnJeffersonWang pushed a commit to ShawnJeffersonWang/kitex that referenced this pull request Aug 7, 2024

feat(generic): support grpc json generic for client (cloudwego#1411)

b0d0355

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(generic): support grpc json generic for client #1411

feat(generic): support grpc json generic for client #1411

Marina-Sakai commented Jun 24, 2024

codecov bot commented Jun 24, 2024 •

edited

Loading

jayantxie left a comment

feat(generic): support grpc json generic for client #1411

feat(generic): support grpc json generic for client #1411

Conversation

Marina-Sakai commented Jun 24, 2024

What type of PR is this?

Check the PR title.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

codecov bot commented Jun 24, 2024 • edited Loading

Codecov Report

jayantxie left a comment

Choose a reason for hiding this comment

codecov bot commented Jun 24, 2024 •

edited

Loading