Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add recover for client's Close #753

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

ppzqh
Copy link
Contributor

@ppzqh ppzqh commented Dec 15, 2022

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

zh: client 的 Close 方法内添加 recover

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

Which issue(s) this PR fixes:

@ppzqh ppzqh requested review from a team as code owners December 15, 2022 08:12
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 69.66% // Head: 69.54% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (8501e0f) compared to base (dd39b82).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #753      +/-   ##
===========================================
- Coverage    69.66%   69.54%   -0.13%     
===========================================
  Files          232      232              
  Lines        17217    17220       +3     
===========================================
- Hits         11994    11975      -19     
- Misses        4140     4156      +16     
- Partials      1083     1089       +6     
Impacted Files Coverage Δ
client/client.go 72.75% <33.33%> (-0.33%) ⬇️
...emote/trans/nphttp2/grpc/grpcframe/frame_reader.go 46.01% <0.00%> (-2.46%) ⬇️
pkg/remote/trans/nphttp2/grpc/controlbuf.go 81.89% <0.00%> (-2.21%) ⬇️
pkg/profiler/profiler.go 73.00% <0.00%> (-1.85%) ⬇️
pkg/remote/trans/nphttp2/grpc/http2_server.go 70.90% <0.00%> (-0.48%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ppzqh ppzqh merged commit 748b280 into cloudwego:develop Dec 15, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants