Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure loop object will not be finalized before serve return #54

Merged
merged 1 commit into from
Sep 28, 2021
Merged

fix: ensure loop object will not be finalized before serve return #54

merged 1 commit into from
Sep 28, 2021

Conversation

joway
Copy link
Member

@joway joway commented Sep 28, 2021

No description provided.

@Hchenn Hchenn changed the title feat: keep alive loop object before serve return fix: keep alive loop object before serve return Sep 28, 2021
@Hchenn Hchenn linked an issue Sep 28, 2021 that may be closed by this pull request
seem it can't work on Mac OSX #52
Closed
@Hchenn Hchenn added the fix fix or hotfix some bugs label Sep 28, 2021
@joway joway force-pushed the feat/keep-alive-loop branch 2 times, most recently from f974f67 to a74cee7 Compare September 28, 2021 04:12
@joway joway changed the title fix: keep alive loop object before serve return fix: ensure loop object will not be finalized before serve return Sep 28, 2021
@joway joway merged commit 0fe1e8a into cloudwego:develop Sep 28, 2021
@joway joway deleted the feat/keep-alive-loop branch September 28, 2021 05:22
@joway joway mentioned this pull request Sep 28, 2021
Merged
@Hchenn Hchenn mentioned this pull request Nov 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hchenn Hchenn Hchenn approved these changes

Assignees
No one assigned
Labels
fix fix or hotfix some bugs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

seem it can't work on Mac OSX
2 participants
@joway @Hchenn