feat: new conn api - Until #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joway
force-pushed
the
feat/read-slice
branch
3 times, most recently
from
83d492d
to
9887c0d
Compare
Closed
Hchenn
reviewed
Jan 7, 2022
joway
force-pushed
the
feat/read-slice
branch
2 times, most recently
from
1740e35
to
43efdf2
Compare
joway
force-pushed
the
feat/read-slice
branch
from
43efdf2
to
924020c
Compare
joway
force-pushed
the
feat/read-slice
branch
from
3226892
to
f4570c4
Compare
joway
force-pushed
the
feat/read-slice
branch
from
6f6f586
to
6c00df3
Compare
Hchenn
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
用户态实现 readslice 性能损耗会更大，因为无法记忆上一次遍历的坐标且还需要把底层二维数组转成一维数组。每次需要重头遍历。