Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: async Thrift input protocol support #123

Merged
merged 4 commits into from
Feb 2, 2023

Conversation

ii64
Copy link
Member

@ii64 ii64 commented Jan 30, 2023

Motivation

Follow up #121, we got new trait called TAsyncInputProtocol (from pilota)

@ii64 ii64 requested review from a team as code owners January 30, 2023 15:21
@PureWhiteWu PureWhiteWu force-pushed the feat/async-trait-input-protocol branch from 2bcbabe to 10a63f4 Compare February 1, 2023 03:11
@PureWhiteWu
Copy link
Member

I will re-trigger the ci after #124 is merged and this pr is rebased.

Copy link
Member

@PureWhiteWu PureWhiteWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks very much for your contribution!

@PureWhiteWu PureWhiteWu merged commit 5f555c1 into cloudwego:main Feb 2, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants