Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(volo-thrift): support clone for errors #380

Merged
merged 1 commit into from
Mar 5, 2024
Merged

feat(volo-thrift): support clone for errors #380

merged 1 commit into from
Mar 5, 2024

Conversation

PureWhiteWu
Copy link
Member

No description provided.

@PureWhiteWu PureWhiteWu added the A-volo-thrift The issue concerns the `volo-thrift` crate. label Mar 4, 2024
@PureWhiteWu PureWhiteWu self-assigned this Mar 4, 2024
@PureWhiteWu PureWhiteWu requested review from a team as code owners March 4, 2024 15:52
@Millione
Copy link
Member

Millione commented Mar 5, 2024

In what scenarios is this clone needed?

@PureWhiteWu
Copy link
Member Author

In what scenarios is this clone needed?

This is needed by some biz, they want to take the ownership of Error and do some custom logic.

@PureWhiteWu PureWhiteWu merged commit ea7b9c1 into main Mar 5, 2024
15 checks passed
@PureWhiteWu PureWhiteWu deleted the feat/error_clone branch March 5, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Millione Millione Millione approved these changes

Assignees

@PureWhiteWu PureWhiteWu

Labels
A-volo-thrift The issue concerns the `volo-thrift` crate.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PureWhiteWu @Millione