feat: grpc server add from_arc #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
PureWhiteWu
force-pushed
the
feature-grpc-server-from-arc
branch
from
2c8bde9
to
6745357
Compare
PureWhiteWu
approved these changes
Apr 7, 2024
There was a problem hiding this comment.
Thanks very much for your contribution!
LGTM, take another look? @Millione
Millione
approved these changes
Apr 7, 2024
Signed-off-by: Haiwei Liu <carllhw@gmail.com>
Millione
force-pushed
the
feature-grpc-server-from-arc
branch
from
6745357
to
088163d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
grpc server add from_arc
refs: https://github.com/hyperium/tonic/blob/eeb3268f71ae5d1107c937392389db63d8f721fb/tonic-build/src/server.rs#L128
Solution