Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CircleCI config #196

Merged
merged 3 commits into from
Oct 8, 2017
Merged

Fix CircleCI config #196

merged 3 commits into from
Oct 8, 2017

Conversation

ataggart
Copy link
Contributor

@ataggart ataggart commented Oct 7, 2017

CCI builds had been failing because the config file was not in the right place.

Alexander Taggart added 3 commits October 7, 2017 14:14
Absolute paths cause problems since different images have different home directories.
@ataggart
Copy link
Contributor Author

ataggart commented Oct 7, 2017

The branch is passing CCI: https://circleci.com/gh/ataggart/cloverage/8

To enable building and reporting the status of a forked PR: https://circleci.com/docs/1.0/fork-pr-builds/

@lvh
Copy link
Collaborator

lvh commented Oct 8, 2017

Thanks for your contribution :)

When I try to access the settings page you referenced, I just continuously get redirected between GitHub and this page:

screen shot 2017-10-08 at 9 55 11 am

... which isn't very helpful, and I don't really have the resources to figure out why it thinks that right now.

@lvh lvh merged commit fb4b7eb into cloverage:master Oct 8, 2017
@lvh
Copy link
Collaborator

lvh commented Oct 8, 2017

(I'm apparently not an owner of the cloverage organization, just of the repo itself.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants