Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete elasticsearch index on deletion, omit trash search results #390

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

max-zilla
Copy link
Contributor

#377

This does 2 things:

  • Files, datasets, collections are removed from Elasticsearch index on deletion.
  • Files, datasets and collections are checked for trash status before display in search results. Search is filtered by ID so hopefully quick retrieval. Not sure how else to double-check ES index isn't out-of-sync.

Currently deleting index doesn't happen on trash, only delete - in theory people might want to search trash? But I'm not sold on this so if we think it should be done on moving to trash I can adjust it.

@max-zilla max-zilla requested a review from a team October 17, 2022 19:36
@lmarini lmarini added this pull request to the merge queue Sep 12, 2023
@lmarini lmarini removed this pull request from the merge queue due to a manual request Sep 12, 2023
@lmarini lmarini merged commit 4f6a6e3 into develop Sep 12, 2023
10 checks passed
@lmarini lmarini deleted the omit-trash-search-results branch September 12, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants