Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable recipient registry #189

Closed
3 tasks done
xuhcc opened this issue Nov 16, 2020 · 0 comments · Fixed by #201
Closed
3 tasks done

Reusable recipient registry #189

xuhcc opened this issue Nov 16, 2020 · 0 comments · Fixed by #201
Assignees
Milestone

Comments

@xuhcc
Copy link
Contributor

xuhcc commented Nov 16, 2020

It should be possible to use recipient registry with multiple funding round factories, but currently SimpleRecipientRegistry allows only single controller.

  • (Short-term solution) Do not call setMaxRecipients() from funding round factory. Trust that maxRecipients is set to correct value.
  • Do not allow decreasing maxRecipients.
  • Allow registry owner to call setMaxRecipients() (?).

There's an edge case where the number of recipients increases beyond MACI's vote option limit during the round (this can lead to users unknowingly voting for invalid vote options).
To prevent it the funding round factory should set maxRecipients at round deployment and lock it until the end of the round. If some other entity will set maxRecipients, it should similarly do that in sync with funding rounds (and with respect to vote option limit of currently deployed MACI instance).

@xuhcc xuhcc added this to the Milestone 4 milestone Nov 16, 2020
@xuhcc xuhcc self-assigned this Nov 16, 2020
xuhcc added a commit to xuhcc/clrfund that referenced this issue Nov 16, 2020
@xuhcc xuhcc modified the milestones: Milestone 4, Milestone 5 Nov 18, 2020
daodesigner pushed a commit that referenced this issue Sep 19, 2021
Removes filename on IPFS image removal [Fixes #20]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant