SpecFlowOSS#2626 Code Cleanup for PR

Modified location of variable declaration in EnumerableValueRetriever to make the code cleaner. Added this change to the changelog.txt
clrudolphi · Aug 19, 2022 · b735e9d · b735e9d
1 parent 59ce192
commit b735e9d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/TechTalk.SpecFlow/Assist/ValueRetrievers/EnumerableValueRetriever.cs b/TechTalk.SpecFlow/Assist/ValueRetrievers/EnumerableValueRetriever.cs
@@ -36,11 +36,10 @@ public object Retrieve(KeyValuePair<string, string> keyValuePair, Type targetTyp
 
         private IEnumerable GetItems(string[] strings, KeyValuePair<string, string> keyValuePair, Type targetType, Type itemType)
         {
-            IValueRetriever retriever = null;
             foreach (var splitValue in strings)
             {
                 var itemKeyValuePair = new KeyValuePair<string, string>(keyValuePair.Key, splitValue.Trim());
-                retriever = GetValueRetriever(itemKeyValuePair, targetType, itemType);
+                var retriever = GetValueRetriever(itemKeyValuePair, targetType, itemType);
                 yield return retriever?.Retrieve(itemKeyValuePair, targetType, itemType);
             }
         }

diff --git a/changelog.txt b/changelog.txt
@@ -5,6 +5,7 @@ Features:
 
 Fixes:
 + Support [TableAliases] also outside `CreateInstance`&`CreateSet`. Fixes #1384
++ EnumerableValueRetriever resolves a ValueRetriever for each element in the enumeration instead of reusing the ValueRetriever of the first item in the list. Fixes #2626
 
 3.9.58