Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syllable length measure for Old Norse (and extendable for Germanic languages) #827

Merged
merged 10 commits into from Sep 11, 2018

Conversation

clemsciences
Copy link
Member

Changes:

  • x and z are added to possible letters,
  • diphtongs are considered as long vowels (suggestions are welcome),
  • measure_old_norse_syllable is the main new function: given a syllable, it calculates its length,
  • old_norse_ipa "language" is introduced: it is not a new language but it is a kind of phonetic system specially made for Old Norse.

@codecov-io
Copy link

codecov-io commented Sep 9, 2018

Codecov Report

Merging #827 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
+ Coverage   89.37%   89.42%   +0.04%     
==========================================
  Files         183      183              
  Lines       11532    11583      +51     
==========================================
+ Hits        10307    10358      +51     
  Misses       1225     1225
Impacted Files Coverage Δ
cltk/tests/test_languages/test_old_norse.py 100% <100%> (ø) ⬆️
cltk/corpus/old_norse/syllabifier.py 100% <100%> (ø) ⬆️
cltk/phonology/syllabify.py 95.67% <100%> (+0.02%) ⬆️
cltk/phonology/old_norse/transcription.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 318e68f...a16b94e. Read the comment docs.

@kylepjohnson
Copy link
Member

kylepjohnson commented Sep 10, 2018 via email

@clemsciences
Copy link
Member Author

Before merging, I should write docs and tests

@clemsciences
Copy link
Member Author

I think it's ready for a merge.

Copy link
Member

@Sedictious Sedictious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oddly enough, I was thinking about something similar just this morning. Overall, such additions are more than welcome, especially concerning the IPA transcription. I don't know whether this is the case with ON, but in certain languages have allophonic vowel length(which is mostly accounted for by IPA transcription), so a fool-proof analysis of quantitative verse is still somewhat unreachable.

I'm also done with my exams, so I'll soon start working on something similar.

@clemsciences clemsciences merged commit 34953a1 into cltk:master Sep 11, 2018
@free-variation
Copy link
Collaborator

This looks neat. Phonology is not my strength, but is there any reason for me to not try to extend this to Old English?

@clemsciences
Copy link
Member Author

I think trying it for Old English is a good thing if you have Old English poems that you can work on.

@clemsciences clemsciences deleted the syllable_length_measure branch January 29, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants