-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syllable length measure for Old Norse (and extendable for Germanic languages) #827
Syllable length measure for Old Norse (and extendable for Germanic languages) #827
Conversation
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
==========================================
+ Coverage 89.37% 89.42% +0.04%
==========================================
Files 183 183
Lines 11532 11583 +51
==========================================
+ Hits 10307 10358 +51
Misses 1225 1225
Continue to review full report at Codecov.
|
I'll merge tomorrow, unless Ria or someone wants to review/merge now. Thx
|
Before merging, I should write docs and tests |
I think it's ready for a merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oddly enough, I was thinking about something similar just this morning. Overall, such additions are more than welcome, especially concerning the IPA transcription. I don't know whether this is the case with ON, but in certain languages have allophonic vowel length(which is mostly accounted for by IPA transcription), so a fool-proof analysis of quantitative verse is still somewhat unreachable.
I'm also done with my exams, so I'll soon start working on something similar.
This looks neat. Phonology is not my strength, but is there any reason for me to not try to extend this to Old English? |
I think trying it for Old English is a good thing if you have Old English poems that you can work on. |
Changes: