Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mv phonology rules nb to cltk.phonology #900

Merged
merged 7 commits into from
Apr 10, 2019
Merged

Mv phonology rules nb to cltk.phonology #900

merged 7 commits into from
Apr 10, 2019

Conversation

kylepjohnson
Copy link
Member

@free-variation I moved out of root (meant to do this a while back).

But it's OK if I just delete it? If so I will update this PR.

@codecov-io
Copy link

codecov-io commented Apr 10, 2019

Codecov Report

Merging #900 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #900   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files         206      206           
  Lines       14043    14043           
=======================================
  Hits        12587    12587           
  Misses       1456     1456

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed1a241...659b30b. Read the comment docs.

@free-variation
Copy link
Collaborator

@kylepjohnson totally -- the notebook is now in tutorials, so this can go. Sorry I forgot to do so myself.

@kylepjohnson kylepjohnson merged commit 4c50952 into cltk:master Apr 10, 2019
Copy link
Collaborator

@free-variation free-variation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants