Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added all tests for testing on travis-ci #3

Merged
merged 5 commits into from Mar 17, 2016
Merged

Added all tests for testing on travis-ci #3

merged 5 commits into from Mar 17, 2016

Conversation

ghost
Copy link

@ghost ghost commented Mar 17, 2016

And now this repo can be integrated with travis-ci.

kylepjohnson added a commit that referenced this pull request Mar 17, 2016
Added all tests for testing on travis-ci
@kylepjohnson kylepjohnson merged commit 106e38b into cltk:master Mar 17, 2016
@ghost
Copy link
Author

ghost commented Mar 17, 2016

Thank you sir.

@ghost ghost deleted the addtests branch March 17, 2016 17:27
@kylepjohnson
Copy link
Member

Thank you! I won't have time to think more about this for a few days. In your opinion, what work remains for this Docker work?

@ghost
Copy link
Author

ghost commented Mar 17, 2016

I think we can do more like mentioned in the main issue #178 we can add cltk_front end and make it serve as a web server.

@kylepjohnson
Copy link
Member

Question: When we build a new container here, can we auto-deploy to Docker Hub?

And will we need to trigger anything manually when a new CLTK release is made?

@ghost
Copy link
Author

ghost commented Mar 17, 2016

When we build a new container here, can we auto-deploy to Docker Hub?

Yes, yesterday when I was looking travis documentation for Docker, I found this feature, but I didn't go deep into it. I will try it out.

And will we need to trigger anything manually when a new CLTK release is made?

Yes we need to build a new image manually based on the new CLTK version. Because, the CLTK gets installed into the container using pip rather than from source.
EDIT These are the temporary answers which I feel right now, they may be incorrect. So I will clarify / confirm more about these questions tomorrow.

@kylepjohnson
Copy link
Member

@achaitanyasai Understood that these are temporary answers, they're appreciated. Let's both do a little research and share what we learn

In the long run, here is what we will want: 1 container for each of our main CLTK software suites (cltk, cltk_api, and cltk_frontend). These will be 3 different containers on Docker Hub. Ideally, everything will build automatically, upon the creation of a new tagged version of the software.

FYI this might mean that we have 3 docker repos OR we keep the Dockerfiles and related scripts in their respective projects.

Thanks a million!

@ghost
Copy link
Author

ghost commented Mar 18, 2016

Let's both do a little research and share what we learn

Yeah sure thank you, right now I am looking into it and get back once I figured out something.

Yes we want 3 different containers. And I think cltk_frontend took care of building docker container already but cltk_api doesn't.

And by the way can you enable Travis-ci service for this repo.

@kylepjohnson
Copy link
Member

Travis enabled! Would you please check the build and add a badge to the README?

@ghost
Copy link
Author

ghost commented Mar 20, 2016

Yeah sure.
And by the way, as I am busy in writing the proposal and searching the corpus, I didn't look into the above question. I will get back to it soon.

@ghost
Copy link
Author

ghost commented Mar 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants