-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search venue by location #358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Pulled branch and ran locally as well and all seems to be working 👍
@@ -140,6 +140,7 @@ defmodule CsGuide.PostcodeLatLong do | |||
# selects all venues 'where' tells it to and adds the :distance key to | |||
# each (:distance is a virtual field that needs to be added to each venue | |||
# as the lat, long and distance variables passed in can all change) | |||
|> order_by([v], desc: v.inserted_at) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Good spot
end | ||
|
||
describe "renders nearby venues - latest venue version" do | ||
setup [:create_venue, :update_venue] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice test 👍 🧠
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonLab looks good. 👍🏻
ref: #357
Select the latest verion of venues when search by location (ie order the venue first then get the unique one based on the entry_id value)