Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search venue by location #358

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Search venue by location #358

merged 2 commits into from
Jan 11, 2019

Conversation

SimonLab
Copy link
Contributor

ref: #357
Select the latest verion of venues when search by location (ie order the venue first then get the unique one based on the entry_id value)

@SimonLab SimonLab self-assigned this Jan 11, 2019
Copy link
Contributor

@RobStallion RobStallion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Pulled branch and ran locally as well and all seems to be working 👍

@@ -140,6 +140,7 @@ defmodule CsGuide.PostcodeLatLong do
# selects all venues 'where' tells it to and adds the :distance key to
# each (:distance is a virtual field that needs to be added to each venue
# as the lat, long and distance variables passed in can all change)
|> order_by([v], desc: v.inserted_at)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good spot

end

describe "renders nearby venues - latest venue version" do
setup [:create_venue, :update_venue]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice test 👍 🧠

Copy link
Contributor

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab looks good. 👍🏻

@nelsonic nelsonic merged commit 0dc0e94 into master Jan 11, 2019
@nelsonic nelsonic deleted the venue-geolocation-image branch January 11, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants