Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand mesoclitic cases #276

Merged
merged 4 commits into from
Oct 13, 2018
Merged

Expand mesoclitic cases #276

merged 4 commits into from
Oct 13, 2018

Conversation

gcgbarbosa
Copy link
Contributor

Added code to cover all mesoclitic cases present in UD_Portuguese_Bosque 2.2

18-19	permitir-lhe-ia	_	_	_	_	_	_	_	_
18	permitiria	permitir	VERB	_	Mood=Cnd|Number=Sing|Person=3|VerbForm=Fin	0	root	_	mesoclitic
19	lhe	ele	PRON	_	Case=Dat|Gender=Masc|Number=Sing|Person=3|PronType=Prs	18	iobj	_	_

MihaiSurdeanu
MihaiSurdeanu approved these changes Oct 1, 2018
View reviewed changes
Copy link
Contributor

@MihaiSurdeanu MihaiSurdeanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@gcgbarbosa
Copy link
Contributor Author

@MihaiSurdeanu when is this getting merged?

@MihaiSurdeanu MihaiSurdeanu merged commit ed539c5 into master Oct 13, 2018
@MihaiSurdeanu MihaiSurdeanu deleted the pt-expantions branch October 13, 2018 19:59
@MihaiSurdeanu
Copy link
Contributor

Are we ready to release a new version?

@gcgbarbosa
Copy link
Contributor Author

No, not yet. I still need to work on post processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MihaiSurdeanu MihaiSurdeanu MihaiSurdeanu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcgbarbosa @MihaiSurdeanu