Move all hash code to HashCode class #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hadn't looked closely enough. It is failing for a specific Scala version. |
|
This consolidates the mathematics of hashing into a centralized location where it can be better observed and reused. It brought to light several issues in both processors and reach which should eventually be addressed. This is part of the effort to get reach to serialize faster, but is optional and should be merged after the rejson branch. There will probably be merge conflicts at that time. |
MihaiSurdeanu
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the computer tally the count needed for finalization and transfer intermediate results from one state to the next. Also show inconsistencies in how hashes are being used.