Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DependencyUtils so that distToRoot can be reused #727

Merged
merged 5 commits into from
Jul 14, 2023

Conversation

kwalcock
Copy link
Member

No description provided.

@kwalcock
Copy link
Member Author

The inner functions distToRoot and countSteps have been pulled out so that they can be reused elsewhere. There is also a distToRootOpt that makes it more obvious that the root may not be reachable.

Copy link
Contributor

@maxaalexeeva maxaalexeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@kwalcock
Copy link
Member Author

This refactoring was added so that Masha doesn't need to do something the hard way next time.

@kwalcock kwalcock merged commit feb8557 into master Jul 14, 2023
@kwalcock kwalcock deleted the kwalcock/distToRoot branch July 14, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants