Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roll back all resource changes in child cluster #194

Merged
merged 2 commits into from Dec 14, 2021
Merged

roll back all resource changes in child cluster #194

merged 2 commits into from Dec 14, 2021

Conversation

lmxia
Copy link
Contributor

@lmxia lmxia commented Dec 6, 2021

What type of PR is this?

kind/feature

What this PR does / why we need it:

roll back all resource changes in child cluster

  • add informers for resources in child clusters, requeue Descriptions when resources change.

Which issue(s) this PR fixes:

Fixes #135
Supercede #189

Special notes for your reviewer:

@lmxia lmxia requested a review from dixudx as a code owner December 6, 2021 10:05
@dixudx dixudx added the kind/feature New feature or request label Dec 7, 2021
@dixudx dixudx added this to the v0.7.0 milestone Dec 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2021

Codecov Report

Merging #194 (267f326) into main (f1506d2) will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #194      +/-   ##
========================================
+ Coverage   7.97%   8.24%   +0.26%     
========================================
  Files         29      31       +2     
  Lines       3837    3943     +106     
========================================
+ Hits         306     325      +19     
- Misses      3508    3591      +83     
- Partials      23      27       +4     
Impacted Files Coverage Δ
...lusternet/clusternet/pkg/utils/resourceinformer.go 0.00% <0.00%> (ø)
.../clusternet/clusternet/pkg/utils/resourceclient.go 0.00% <0.00%> (ø)
...ithub.com/clusternet/clusternet/pkg/utils/slice.go 100.00% <0.00%> (+3.57%) ⬆️
...ub.com/clusternet/clusternet/pkg/utils/deployer.go 3.57% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1506d2...267f326. Read the comment docs.

pkg/agent/deployer/generic/generic.go Outdated Show resolved Hide resolved
pkg/controllers/apps/resource/resource.go Show resolved Hide resolved
pkg/controllers/apps/resource/resource.go Outdated Show resolved Hide resolved
pkg/utils/deployer_test.go Show resolved Hide resolved
pkg/utils/deployer_test.go Outdated Show resolved Hide resolved
pkg/controllers/apps/resource/resource.go Show resolved Hide resolved
pkg/controllers/apps/resource/resource.go Outdated Show resolved Hide resolved
pkg/utils/deployer.go Show resolved Hide resolved
pkg/utils/deployer.go Outdated Show resolved Hide resolved
pkg/utils/resourceinformer.go Outdated Show resolved Hide resolved
lmxia and others added 2 commits December 13, 2021 15:17
Signed-off-by: Lingming Xia <xialingming@gmail.com>
Signed-off-by: Di Xu <stephenhsu90@gmail.com>
@dixudx dixudx merged commit 9e7384d into clusternet:main Dec 14, 2021
@dixudx dixudx changed the title sync back changes in child cluster roll back all resource changes in child cluster Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to reconcile/rollback changes in child cluster
3 participants