Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix changes rolling back in child cluster #242

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

lmxia
Copy link
Contributor

@lmxia lmxia commented Jan 24, 2022

Signed-off-by: lmxia xialingming@gmail.com

What type of PR is this?

kind/bug

What this PR does / why we need it:

When child clusters are running with syncMode Push/Dual, changes will not be rolled back as expected.

Which issue(s) this PR fixes:

Fixes #236
This is a follow up of #194

Special notes for your reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2022

Codecov Report

Merging #242 (d2b4cfb) into main (cb31a7c) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   10.46%   10.52%   +0.05%     
==========================================
  Files          39       39              
  Lines        4260     4267       +7     
==========================================
+ Hits          446      449       +3     
- Misses       3781     3786       +5     
+ Partials       33       32       -1     
Impacted Files Coverage Δ
...ub.com/clusternet/clusternet/pkg/utils/deployer.go 3.52% <0.00%> (-0.05%) ⬇️
...ernet/clusternet/pkg/hub/apiserver/shadow/utils.go 100.00% <0.00%> (+10.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb31a7c...d2b4cfb. Read the comment docs.

@dixudx dixudx added this to the v0.8.0 milestone Feb 28, 2022
@dixudx dixudx added the kind/bug Something isn't working label Feb 28, 2022
Signed-off-by: lmxia <xialingming@gmail.com>
@lmxia lmxia force-pushed the enable-resource-persistent branch from 245c437 to d2b4cfb Compare March 1, 2022 01:43
@dixudx dixudx changed the title add resource persistence enabled. fix changes rolling back in child cluster Mar 1, 2022
@dixudx dixudx merged commit 6aefc23 into clusternet:main Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changes not rolled back in child cluster when working in Dual/Push syncMode
3 participants