Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug to download chart from registry #257

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

willzgli
Copy link
Contributor

@willzgli willzgli commented Mar 3, 2022

Signed-off-by: willzgli willzgli@tencent.com

fix bug to downlaod a chart from registry

What type of PR is this?
kind/bug

What this PR does / why we need it:
download chart from the registry and install it in child clusters

Which issue(s) this PR fixes:
Fixes #256 #244

Special notes for your reviewer:

Signed-off-by: willzgli <willzgli@tencent.com>
@dixudx dixudx added this to the v0.8.0 milestone Mar 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #257 (cdc54c4) into main (e5930fa) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
- Coverage   10.43%   10.41%   -0.03%     
==========================================
  Files          39       39              
  Lines        4302     4311       +9     
==========================================
  Hits          449      449              
- Misses       3821     3830       +9     
  Partials       32       32              
Impacted Files Coverage Δ
...ithub.com/clusternet/clusternet/pkg/utils/chart.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5930fa...cdc54c4. Read the comment docs.

@dixudx dixudx merged commit 044df38 into clusternet:main Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fail to download chart from registry
3 participants