Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pointer for podstatistics and resourceusage #421

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

DanielXLee
Copy link
Contributor

@DanielXLee DanielXLee commented Jul 14, 2022

What type of PR is this?

What this PR does / why we need it:

introduced by #362

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@DanielXLee DanielXLee requested review from a team as code owners July 14, 2022 05:07
@DanielXLee DanielXLee requested a review from dixudx July 14, 2022 05:07
@dixudx dixudx added this to the v0.11.0 milestone Jul 14, 2022
@dixudx dixudx added the kind/bug Something isn't working label Jul 14, 2022
Signed-off-by: danielxxli <danielxxli@tencent.com>
Copy link
Member

@dixudx dixudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix.

@codecov-commenter
Copy link

Codecov Report

Merging #421 (932e83c) into main (33de040) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #421   +/-   ##
=======================================
  Coverage   13.68%   13.69%           
=======================================
  Files          60       60           
  Lines        6578     6574    -4     
=======================================
  Hits          900      900           
+ Misses       5612     5608    -4     
  Partials       66       66           
Impacted Files Coverage Δ
...clusters/clusterstatus/clusterstatus_controller.go 5.40% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33de040...932e83c. Read the comment docs.

@dixudx dixudx merged commit 80b1b45 into clusternet:main Jul 14, 2022
@dixudx dixudx deleted the fix-status branch July 14, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants