Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only enable service import/export controllers after EndpointSlice v1beta1 promoted #529

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

mars1024
Copy link
Contributor

@mars1024 mars1024 commented Nov 8, 2022

Signed-off-by: Bruce Ma brucema19901024@gmail.com

What type of PR is this?

/bugfix

What this PR does / why we need it:

To enable controllers iff necessary.

Which issue(s) this PR fixes:

Fixes #519

Special notes for your reviewer:

…eta1 promoted

Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
@mars1024 mars1024 requested review from a team as code owners November 8, 2022 03:40
@mars1024
Copy link
Contributor Author

mars1024 commented Nov 8, 2022

/assign @dixudx

@mars1024
Copy link
Contributor Author

mars1024 commented Nov 8, 2022

/retest

@dixudx dixudx added this to the v0.13.0 milestone Nov 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #529 (0960b56) into main (c4a855b) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
+ Coverage   13.55%   13.58%   +0.03%     
==========================================
  Files          65       65              
  Lines        7120     7148      +28     
==========================================
+ Hits          965      971       +6     
- Misses       6079     6101      +22     
  Partials       76       76              
Impacted Files Coverage Δ
...rc/github.com/clusternet/clusternet/pkg/hub/hub.go 2.51% <0.00%> (-0.08%) ⬇️
...ithub.com/clusternet/clusternet/pkg/agent/agent.go 1.61% <0.00%> (-0.05%) ⬇️
...hub.com/clusternet/clusternet/pkg/utils/version.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@dixudx dixudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Thanks for the contribution.

@dixudx dixudx merged commit fa32193 into clusternet:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not starting serviceImportController for Kubernetes lower than v1.17
3 participants