Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serve metrics in clusternet-agent #608

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Conversation

xieydd
Copy link
Contributor

@xieydd xieydd commented Feb 24, 2023

What type of PR is this?

kind/feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: xieydd <xieydd@gmail.com>
@xieydd xieydd requested a review from a team as a code owner February 24, 2023 03:19
@xieydd xieydd requested a review from yiwei-C February 24, 2023 03:19
@codecov-commenter
Copy link

Codecov Report

Merging #608 (327fbe6) into main (e2ffa5f) will decrease coverage by 0.41%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
- Coverage   13.60%   13.19%   -0.41%     
==========================================
  Files          66       71       +5     
  Lines        7492     7792     +300     
==========================================
+ Hits         1019     1028       +9     
- Misses       6391     6681     +290     
- Partials       82       83       +1     
Impacted Files Coverage Δ
...ernet/clusternet/pkg/hub/apiserver/shadow/utils.go 89.28% <0.00%> (-10.72%) ⬇️
...m/clusternet/clusternet/pkg/scheduler/scheduler.go 3.82% <0.00%> (-0.12%) ⬇️
...ithub.com/clusternet/clusternet/pkg/agent/agent.go 1.42% <0.00%> (-0.07%) ⬇️
...et/clusternet/pkg/registry/shadow/template/rest.go 2.87% <0.00%> (-0.01%) ⬇️
...hub.com/clusternet/clusternet/pkg/utils/options.go 0.00% <0.00%> (ø)
.../clusternet/clusternet/pkg/agent/status_manager.go 0.00% <0.00%> (ø)
...t/clusternet/pkg/registry/shadow/template/scale.go 0.00% <0.00%> (ø)
...github.com/clusternet/clusternet/pkg/utils/flag.go
...thub.com/clusternet/clusternet/pkg/agent/option.go
...ternet/clusternet/pkg/scheduler/apis/validation.go 42.85% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dixudx dixudx added this to the v0.15.0 milestone Feb 24, 2023
@dixudx dixudx added the kind/feature New feature or request label Feb 24, 2023
Copy link
Member

@dixudx dixudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work.

@dixudx dixudx merged commit fa490e7 into clusternet:main Feb 24, 2023
@dixudx dixudx mentioned this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants