Add React helpers #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nopelluhh
force-pushed
the
noah.react_helpers
branch
from
8ffab2c
to
598145a
Compare
nopelluhh
force-pushed
the
noah.react_helpers
branch
from
598145a
to
9d1f29a
Compare
bcharna
reviewed
Nov 4, 2021
| }; | ||
|
|
||
| export const createProvider = < | ||
| Params extends Record<string | number, any> = WTEventParams |
There was a problem hiding this comment.
do we want to allow number keys?
There was a problem hiding this comment.
i don't think there's a particular reason to exclude them?
There was a problem hiding this comment.
curious what a practical use case would be, but don't feel strongly about excluding them.
nopelluhh
force-pushed
the
noah.react_helpers
branch
from
016069b
to
46ccc92
Compare
nopelluhh
force-pushed
the
noah.react_helpers
branch
from
46ccc92
to
3412978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
WTProvider,useTrackanduseWThooksclientandreactcodeCallouts
yarn.lockwas also deduped as part of adding newreactdependencies.