-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add React helpers #47
Conversation
8ffab2c
to
598145a
Compare
598145a
to
9d1f29a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is neat! just a handful of small comments/questions
}; | ||
|
||
export const createProvider = < | ||
Params extends Record<string | number, any> = WTEventParams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to allow number keys?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think there's a particular reason to exclude them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious what a practical use case would be, but don't feel strongly about excluding them.
016069b
to
46ccc92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work on this!
46ccc92
to
3412978
Compare
Changes
WTProvider
,useTrack
anduseWT
hooksclient
andreact
codeCallouts
yarn.lock
was also deduped as part of adding newreact
dependencies.