Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visitor token override position #66

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Fix visitor token override position #66

merged 2 commits into from
Feb 27, 2023

Conversation

nopelluhh
Copy link
Member

@nopelluhh nopelluhh commented Feb 27, 2023 •
edited
Loading

Context

This was supposed to be a top level param, but @nopelluhh put it in the wrong spot 🙃

Changes

  • Clean up unnoticed type errors in the client spec
  • Move custom visitor token setting to config call and add test cases for sending events + reading visitor token

@nopelluhh nopelluhh merged commit 332fc46 into master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksylvest ksylvest ksylvest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nopelluhh @ksylvest