Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on amd64 Gentoo #7

Merged
merged 4 commits into from
Sep 19, 2016
Merged

Fix build on amd64 Gentoo #7

merged 4 commits into from
Sep 19, 2016

Conversation

0181532686cf4a31163be0bf3e6bb6732bf
Copy link
Contributor

This should fix #3 and #4 (worked for me)

Copy link
Member

@unbornchikken unbornchikken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will break toolset version detection when format is just x.y instead of x.y.z. I believe [0-9]+\\.[0-9]+(?:\\.[0-9]+)? would be the correct form. Could you try this at your side?

@unbornchikken
Copy link
Member

Dunno what I have approved, this new UI kinda confusing. @lyssdod could you try that regex at your side?

@0181532686cf4a31163be0bf3e6bb6732bf
Copy link
Contributor Author

@unbornchikken Thanks! After some testing I've added correct regex to handle both x.y.z and x.y compiler versions

@unbornchikken unbornchikken merged commit c7ace6f into cmake-js:master Sep 19, 2016
@unbornchikken
Copy link
Member

On.

@0181532686cf4a31163be0bf3e6bb6732bf
Copy link
Contributor Author

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add an option to b2
2 participants