Add --ignore-site-config to fix modular boost build #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Gentoo Linux, the OOTB Boost configuration file has some invalid options which breaks b2 execution. The official (prescribed) way is to ignore the site configuration file. Source http://lists.boost.org/boost-users/2014/04/81846.php Fix cmake-js#3 Fix cmake-js/cmake-js#58
|
cc @lyssdod |
|
@unbornchikken, we can certainly detect Gentoo OS (via uname, I have a cmake patch ready) and add this option conditionally, but IMO there is no point of relying on the local configuration. Please let me know if you disagree; I will nest it under the condition. :) |
|
Thank you. LGTM. @lyssdod could you try this PR at your side? |
|
Thank you guys! I've tried and it failed. I will submit a PR which fixes it for me |
|
Closed in favor of #7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Gentoo Linux, the OOTB Boost configuration file has some invalid
options which breaks b2 execution. The official (prescribed) way is to
ignore the site configuration file.
Source http://lists.boost.org/boost-users/2014/04/81846.php
Fix #3
Fix cmake-js/cmake-js#58