Fix take ammo for most ranged spells

[cala]

Fix spells like Arcane Shot not taking ammo while they should

This commit c653a66 is one of those pending backports from old mangos-zero concatenated in: https://github.com/cmangos/issues/wiki/classic_backporting-todo-zero-commits

stfx adviced to first apply to TBC, then backport to classic

I tested it and this is my report:

cala: tested take ammo and found issue on current revision: ammo are not taken for all spells (ex: ‘arcane shot’ does not take ammo but ‘serpent sting’ does). However, if no ammo in inventory no ranged spell can be casted, even those like ‘arcane shot’ that do not take ammo (though probably should take). I’ll try to test this commit.
stfx: was this behavior ever changed? it should be tested/fixed on tbc also if needed
cala (march 13-13): this fix does allow all spells to take ammo. It should be applied to TBC firsthand, then backported to classic.

[Schmoozerd]

How would this be on wotlk?
Because actually i do like the idea of refactoring the TakeAmmo code into a single function :)

[cala]

I don't know if this is suitable or not for wotlk. I'll do some research regarding change in ammo between tbc and wotlk and I'll test with last wotlk core if this commit is relevant. Does that sound ok?

[Schmoozerd]

that sounds great - thank you! ;)

[cala]

Alright. Patch notes do not state big changes in ammunitions before cata expansion. I also tested wotlk and I think I noticed the same behavior than in TBC and classic. I said think because the character was shooting so fast a mix of autoshot and arcane shot, that it was hard to keep count of ammunition removed. Let's say I am 90% sure the behavior is the same in the three cores.
Thus, this commit should also applied for wotlk (at 90% 😉 )

Do you want that I close this pull request and open a new one for wotlk?

[Schmoozerd]

hmm, i think i can simply take the patch from here as well :)
so a pull request should not be required
Poke @Stfx to remind me to not forget this here