Revert "Made script library link statically, thereby eliminating DLL …

…export related compiler warnings with Visual Studio"

This reverts commit 409f11f.

src/framework/GameSystem/GridReference.h

@@ -24,7 +24,7 @@
 template<class OBJECT> class GridRefManager;
 
 template<class OBJECT>
-class GridReference : public Reference<GridRefManager<OBJECT>, OBJECT>
+class MANGOS_DLL_SPEC GridReference : public Reference<GridRefManager<OBJECT>, OBJECT>
 {
     protected:
 

src/framework/Platform/Define.h

@@ -80,10 +80,12 @@
 #endif // PLATFORM
 
 #if PLATFORM == PLATFORM_WINDOWS
+#  define MANGOS_DLL_SPEC __declspec(dllexport)
 #  ifndef DECLSPEC_NORETURN
 #    define DECLSPEC_NORETURN __declspec(noreturn)
 #  endif // DECLSPEC_NORETURN
 #else // PLATFORM != PLATFORM_WINDOWS
+#  define MANGOS_DLL_SPEC
 #  define DECLSPEC_NORETURN
 #endif // PLATFORM
 

src/framework/Policies/ObjectLifeTime.cpp

@@ -26,7 +26,7 @@ namespace MaNGOS
         std::atexit((void (*)())p);
     }
 
-    void at_exit(void (*func)())
+    void MANGOS_DLL_SPEC at_exit(void (*func)())
     {
         external_wrapper((void*)func);
     }

src/framework/Policies/ObjectLifeTime.h

@@ -26,7 +26,7 @@ typedef void (* Destroyer)(void);
 
 namespace MaNGOS
 {
-    void at_exit(void (*func)());
+    void MANGOS_DLL_SPEC at_exit(void (*func)());
 
     template<class T>
     class ObjectLifeTime

src/framework/Utilities/LinkedList.h

@@ -24,7 +24,7 @@
 //============================================
 class LinkedListHead;
 
-class LinkedListElement
+class MANGOS_DLL_SPEC LinkedListElement
 {
     private:
 
@@ -82,7 +82,7 @@ class LinkedListElement
 
 //============================================
 
-class LinkedListHead
+class MANGOS_DLL_SPEC LinkedListHead
 {
     private:
 

src/framework/Utilities/LinkedReference/Reference.h

@@ -24,7 +24,7 @@
 //=====================================================
 
 template<class TO, class FROM>
-class Reference : public LinkedListElement
+class MANGOS_DLL_SPEC Reference : public LinkedListElement
 {
     private:
 

src/game/AI/CreatureAI.h

@@ -93,7 +93,7 @@ enum AIEventType
     AI_EVENT_CUSTOM_F           = 1005,
 };
 
-class CreatureAI
+class MANGOS_DLL_SPEC CreatureAI
 {
     public:
         explicit CreatureAI(Creature* creature) :

src/game/AI/CreatureEventAI.h

@@ -634,7 +634,7 @@ struct CreatureEventAIHolder
     bool UpdateRepeatTimer(Creature* creature, uint32 repeatMin, uint32 repeatMax);
 };
 
-class CreatureEventAI : public CreatureAI
+class MANGOS_DLL_SPEC CreatureEventAI : public CreatureAI
 {
     public:
         explicit CreatureEventAI(Creature* c);

src/game/AI/GuardianAI.h

@@ -27,7 +27,7 @@
 class Creature;
 class Spell;
 
-class GuardianAI : public CreatureEventAI
+class MANGOS_DLL_SPEC GuardianAI : public CreatureEventAI
 {
 public:
 

src/game/Camera.h

@@ -29,7 +29,7 @@ class WorldPacket;
 class Player;
 
 /// Camera - object-receiver. Receives broadcast packets from nearby worldobjects, object visibility changes and sends them to client
-class Camera
+class MANGOS_DLL_SPEC Camera
 {
         friend class ViewPoint;
     public:
@@ -77,7 +77,7 @@ class Camera
 };
 
 /// Object-observer, notifies farsight object state to cameras that attached to it
-class ViewPoint
+class MANGOS_DLL_SPEC ViewPoint
 {
         friend class Camera;
 

src/game/Chat.h

@@ -75,7 +75,7 @@ enum PlayerChatTag
 };
 typedef uint32 ChatTagFlags;
 
-class ChatHandler
+class MANGOS_DLL_SPEC ChatHandler
 {
     public:
         explicit ChatHandler(WorldSession* session);

src/game/ConfusedMovementGenerator.h

@@ -22,7 +22,7 @@
 #include "MovementGenerator.h"
 
 template<class T>
-class ConfusedMovementGenerator
+class MANGOS_DLL_SPEC ConfusedMovementGenerator
     : public MovementGeneratorMedium< T, ConfusedMovementGenerator<T> >
 {
     public:

src/game/Creature.h

@@ -490,7 +490,7 @@ enum TemporaryFactionFlags                                  // Used at real fact
     TEMPFACTION_ALL,
 };
 
-class Creature : public Unit
+class MANGOS_DLL_SPEC Creature : public Unit
 {
         CreatureAI* i_AI;
         CreatureAI* m_pausedAI;                             // Main AI will be stored here during the possessing

src/game/DBCStores.cpp

@@ -982,11 +982,11 @@ uint32 GetCreatureModelRace(uint32 model_id)
 }
 
 // script support functions
-DBCStorage <SoundEntriesEntry>  const* GetSoundEntriesStore()   { return &sSoundEntriesStore;   }
-DBCStorage <SpellEntry>         const* GetSpellStore()          { return &sSpellStore;          }
-DBCStorage <SpellRangeEntry>    const* GetSpellRangeStore()     { return &sSpellRangeStore;     }
-DBCStorage <FactionEntry>       const* GetFactionStore()        { return &sFactionStore;        }
-DBCStorage <ItemEntry>          const* GetItemDisplayStore()    { return &sItemStore;           }
-DBCStorage <CreatureDisplayInfoEntry> const* GetCreatureDisplayStore() { return &sCreatureDisplayInfoStore; }
-DBCStorage <EmotesEntry>        const* GetEmotesStore()         { return &sEmotesStore;         }
-DBCStorage <EmotesTextEntry>    const* GetEmotesTextStore()     { return &sEmotesTextStore;     }
+MANGOS_DLL_SPEC DBCStorage <SoundEntriesEntry>  const* GetSoundEntriesStore()   { return &sSoundEntriesStore;   }
+MANGOS_DLL_SPEC DBCStorage <SpellEntry>         const* GetSpellStore()          { return &sSpellStore;          }
+MANGOS_DLL_SPEC DBCStorage <SpellRangeEntry>    const* GetSpellRangeStore()     { return &sSpellRangeStore;     }
+MANGOS_DLL_SPEC DBCStorage <FactionEntry>       const* GetFactionStore()        { return &sFactionStore;        }
+MANGOS_DLL_SPEC DBCStorage <ItemEntry>          const* GetItemDisplayStore()    { return &sItemStore;           }
+MANGOS_DLL_SPEC DBCStorage <CreatureDisplayInfoEntry> const* GetCreatureDisplayStore() { return &sCreatureDisplayInfoStore; }
+MANGOS_DLL_SPEC DBCStorage <EmotesEntry>        const* GetEmotesStore()         { return &sEmotesStore;         }
+MANGOS_DLL_SPEC DBCStorage <EmotesTextEntry>    const* GetEmotesTextStore()     { return &sEmotesTextStore;     }

src/game/DBCStores.h

@@ -41,8 +41,8 @@ uint32 GetAreaFlagByMapId(uint32 mapid);
 
 WMOAreaTableEntry const* GetWMOAreaTableEntryByTripple(int32 rootid, int32 adtid, int32 groupid);
 
-AreaTableEntry const* GetAreaEntryByAreaID(uint32 area_id);
-AreaTableEntry const* GetAreaEntryByAreaFlagAndMap(uint32 area_flag, uint32 map_id);
+MANGOS_DLL_SPEC AreaTableEntry const* GetAreaEntryByAreaID(uint32 area_id);
+MANGOS_DLL_SPEC AreaTableEntry const* GetAreaEntryByAreaFlagAndMap(uint32 area_flag, uint32 map_id);
 
 uint32 GetVirtualMapForMapAndZone(uint32 mapid, uint32 zoneId);
 
@@ -93,7 +93,7 @@ bool IsPointInAreaTriggerZone(AreaTriggerEntry const* atEntry, uint32 mapid, flo
 PvPDifficultyEntry const* GetBattlegroundBracketByLevel(uint32 mapid, uint32 level);
 PvPDifficultyEntry const* GetBattlegroundBracketById(uint32 mapid, BattleGroundBracketId id);
 
-uint32 GetCreatureModelRace(uint32 model_id);
+MANGOS_DLL_SPEC uint32 GetCreatureModelRace(uint32 model_id);
 
 extern DBCStorage <AchievementEntry>             sAchievementStore;
 extern DBCStorage <AchievementCriteriaEntry>     sAchievementCriteriaStore;
@@ -207,13 +207,13 @@ extern DBCStorage <WorldSafeLocsEntry>           sWorldSafeLocsStore;
 void LoadDBCStores(const std::string& dataPath);
 
 // script support functions
-DBCStorage <SoundEntriesEntry>          const* GetSoundEntriesStore();
-DBCStorage <SpellEntry>                 const* GetSpellStore();
-DBCStorage <SpellRangeEntry>            const* GetSpellRangeStore();
-DBCStorage <FactionEntry>               const* GetFactionStore();
-DBCStorage <ItemEntry>                  const* GetItemDisplayStore();
-DBCStorage <CreatureDisplayInfoEntry>   const* GetCreatureDisplayStore();
-DBCStorage <EmotesEntry>                const* GetEmotesStore();
-DBCStorage <EmotesTextEntry>            const* GetEmotesTextStore();
+MANGOS_DLL_SPEC DBCStorage <SoundEntriesEntry>          const* GetSoundEntriesStore();
+MANGOS_DLL_SPEC DBCStorage <SpellEntry>                 const* GetSpellStore();
+MANGOS_DLL_SPEC DBCStorage <SpellRangeEntry>            const* GetSpellRangeStore();
+MANGOS_DLL_SPEC DBCStorage <FactionEntry>               const* GetFactionStore();
+MANGOS_DLL_SPEC DBCStorage <ItemEntry>                  const* GetItemDisplayStore();
+MANGOS_DLL_SPEC DBCStorage <CreatureDisplayInfoEntry>   const* GetCreatureDisplayStore();
+MANGOS_DLL_SPEC DBCStorage <EmotesEntry>                const* GetEmotesStore();
+MANGOS_DLL_SPEC DBCStorage <EmotesTextEntry>            const* GetEmotesTextStore();
 
 #endif

src/game/FleeingMovementGenerator.h

@@ -23,7 +23,7 @@
 #include "ObjectGuid.h"
 
 template<class T>
-class FleeingMovementGenerator
+class MANGOS_DLL_SPEC FleeingMovementGenerator
     : public MovementGeneratorMedium< T, FleeingMovementGenerator<T> >
 {
     public:
@@ -45,7 +45,7 @@ class FleeingMovementGenerator
         TimeTracker i_nextCheckTime;
 };
 
-class TimedFleeingMovementGenerator
+class MANGOS_DLL_SPEC TimedFleeingMovementGenerator
     : public FleeingMovementGenerator<Creature>
 {
     public:

src/game/FollowerReference.h

@@ -24,7 +24,7 @@
 class TargetedMovementGeneratorBase;
 class Unit;
 
-class FollowerReference : public Reference<Unit, TargetedMovementGeneratorBase>
+class MANGOS_DLL_SPEC FollowerReference : public Reference<Unit, TargetedMovementGeneratorBase>
 {
     protected:
         void targetObjectBuildLink() override;

src/game/GameEventMgr.cpp

@@ -1046,7 +1046,7 @@ bool GameEventMgr::IsActiveHoliday(HolidayIds id)
     return false;
 }
 
-bool IsHolidayActive(HolidayIds id)
+MANGOS_DLL_SPEC bool IsHolidayActive(HolidayIds id)
 {
     return sGameEventMgr.IsActiveHoliday(id);
 }

src/game/GameEventMgr.h

@@ -131,6 +131,6 @@ class GameEventMgr
 
 #define sGameEventMgr MaNGOS::Singleton<GameEventMgr>::Instance()
 
-bool IsHolidayActive(HolidayIds id);
+MANGOS_DLL_SPEC bool IsHolidayActive(HolidayIds id);
 
 #endif

src/game/GameObject.h

@@ -609,7 +609,7 @@ struct GameObjectDisplayInfoEntry;
 
 #define GO_ANIMPROGRESS_DEFAULT 0xFF
 
-class GameObject : public WorldObject
+class MANGOS_DLL_SPEC GameObject : public WorldObject
 {
     public:
         explicit GameObject();

src/game/GossipDef.h

@@ -155,7 +155,7 @@ struct QuestMenuItem
 
 typedef std::vector<QuestMenuItem> QuestMenuItemList;
 
-class GossipMenu
+class MANGOS_DLL_SPEC GossipMenu
 {
     public:
         explicit GossipMenu(WorldSession* session);
@@ -243,7 +243,7 @@ class QuestMenu
         QuestMenuItemList m_qItems;
 };
 
-class PlayerMenu
+class MANGOS_DLL_SPEC PlayerMenu
 {
     private:
         GossipMenu mGossipMenu;

src/game/GridMap.h

@@ -184,7 +184,7 @@ class GridMap
 };
 
 template<typename Countable>
-class Referencable
+class MANGOS_DLL_SPEC Referencable
 {
     public:
         Referencable() { m_count = 0; }
@@ -208,7 +208,7 @@ class Referencable
 #define DEFAULT_WATER_SEARCH      50.0f                     // default search distance to case detection water level
 
 // class for sharing and managin GridMap objects
-class TerrainInfo : public Referencable<std::atomic_long>
+class MANGOS_DLL_SPEC TerrainInfo : public Referencable<std::atomic_long>
 {
     public:
         TerrainInfo(uint32 mapid);

src/game/Group.h

@@ -114,7 +114,7 @@ struct InstanceGroupBind
 
 /** request member stats checken **/
 /** todo: uninvite people that not accepted invite **/
-class Group
+class MANGOS_DLL_SPEC Group
 {
     public:
         struct MemberSlot

src/game/GroupReference.h

@@ -24,7 +24,7 @@
 class Group;
 class Player;
 
-class GroupReference : public Reference<Group, Player>
+class MANGOS_DLL_SPEC GroupReference : public Reference<Group, Player>
 {
     protected:
         uint8 iSubGroup;

src/game/HomeMovementGenerator.h

@@ -24,10 +24,10 @@
 class Creature;
 
 template < class T >
-class HomeMovementGenerator;
+class MANGOS_DLL_SPEC HomeMovementGenerator;
 
 template <>
-class HomeMovementGenerator<Creature>
+class MANGOS_DLL_SPEC HomeMovementGenerator<Creature>
     : public MovementGeneratorMedium< Creature, HomeMovementGenerator<Creature> >
 {
     public:

src/game/IdleMovementGenerator.h

@@ -21,7 +21,7 @@
 
 #include "MovementGenerator.h"
 
-class IdleMovementGenerator : public MovementGenerator
+class MANGOS_DLL_SPEC IdleMovementGenerator : public MovementGenerator
 {
     public:
 
@@ -35,7 +35,7 @@ class IdleMovementGenerator : public MovementGenerator
 
 extern IdleMovementGenerator si_idleMovement;
 
-class DistractMovementGenerator : public MovementGenerator
+class MANGOS_DLL_SPEC DistractMovementGenerator : public MovementGenerator
 {
     public:
         explicit DistractMovementGenerator(uint32 timer) : m_timer(timer) {}
@@ -51,7 +51,7 @@ class DistractMovementGenerator : public MovementGenerator
         uint32 m_timer;
 };
 
-class AssistanceDistractMovementGenerator : public DistractMovementGenerator
+class MANGOS_DLL_SPEC AssistanceDistractMovementGenerator : public DistractMovementGenerator
 {
     public:
         AssistanceDistractMovementGenerator(uint32 timer) :

src/game/InstanceData.h

@@ -61,7 +61,7 @@ enum EncounterFrameTypes                                    // only raid UI spec
     ENCOUNTER_FRAME_UNK7                    = 7             // sorting encounter units
 };
 
-class InstanceData
+class MANGOS_DLL_SPEC InstanceData
 {
     public:
 

src/game/Item.h

@@ -269,7 +269,7 @@ struct ItemRequiredTarget
 
 bool ItemCanGoIntoBag(ItemPrototype const* proto, ItemPrototype const* pBagProto);
 
-class Item : public Object
+class MANGOS_DLL_SPEC Item : public Object
 {
     public:
         static Item* CreateItem(uint32 item, uint32 count, Player const* player = nullptr, uint32 randomPropertyId = 0);