Skip to content

Commit

Permalink
Fix ready check in battlegrounds
Browse files Browse the repository at this point in the history
What we had:
* When BG group officer initiates readycheck, it is broadcasted among bg group members (Correct).
* When normal group officer initiates readycheck it is broadcasted among normal group members, but also includes members in BG (Players in BG see a glitched popup without a portrait - Incorrect).
* Same applied to newly introduced ready check finish broadcasts.

According to wowwiki, the ready check popup should not appear for group members who are in a battleground.
Fixed.
  • Loading branch information
Warlockbugs committed Oct 14, 2016
1 parent 0d1453e commit 70b4151
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/game/GroupHandler.cpp
Expand Up @@ -586,7 +586,7 @@ void WorldSession::HandleRaidReadyCheckOpcode(WorldPacket& recv_data)
// everything is fine, do it
WorldPacket data(MSG_RAID_READY_CHECK, 8);
data << ObjectGuid(GetPlayer()->GetObjectGuid());
group->BroadcastPacket(&data, false, -1);
group->BroadcastPacket(&data, true, -1);

group->OfflineReadyCheck();
}
Expand Down Expand Up @@ -618,7 +618,7 @@ void WorldSession::HandleRaidReadyCheckFinishedOpcode(WorldPacket& /*recv_data*/

// Broadcast finish:
WorldPacket data(MSG_RAID_READY_CHECK_FINISHED, 0);
group->BroadcastPacket(&data, false, -1);
group->BroadcastPacket(&data, true, -1);
}

void WorldSession::BuildPartyMemberStatsChangedPacket(Player* player, WorldPacket* data)
Expand Down

0 comments on commit 70b4151

Please sign in to comment.