Skip to content

Commit

Permalink
Revert "Do not send aura update all opcode if no aura to send."
Browse files Browse the repository at this point in the history 
Empty opcode will remove all aura of specified unit on client.

This reverts commit 127187f.

Thank to @Dramacydal for pointing that.
  • Loading branch information
Cyberium committed May 1, 2016
1 parent 88524e5 commit 8f3082a
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/game/Player.cpp
View file
Expand Up @@ -20151,10 +20151,6 @@ void Player::SendAurasForTarget(Unit* target)
data << target->GetPackGUID();

Unit::VisibleAuraMap const& visibleAuras = target->GetVisibleAuras();

if (visibleAuras.empty())
return;

for (Unit::VisibleAuraMap::const_iterator itr = visibleAuras.begin(); itr != visibleAuras.end(); ++itr)
{
SpellAuraHolderConstBounds bounds = target->GetSpellAuraHolderBounds(itr->second);
Expand Down

6 comments on commit 8f3082a

@xfurry
Copy link
Member

@xfurry xfurry commented on 8f3082a May 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyberium
One of your recent commits broke some stacking rules for auras.
For example spell http://www.wowhead.com/spell=31611/bloodmyst-tesla which is cast from many npcs on creature http://www.wowhead.com/npc=17678/sironas worked fine (all npcs were able to channel auras on the target).
Now, only the last caster can channel, and all the rest are interrupted. And if a new caster comes in (for example player), the previous caster also stops.

Do you have any idea if you recent changes could have affected this? I remember that a few weeks ago, before I went in holiday, the scenario described above worked fine.

@cyberium
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i did some change on channeled spell. I will try to figure out whats regression i introduced.

@xfurry
Copy link
Member

@xfurry xfurry commented on 8f3082a May 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point me to the place where you did the changes, please?

@cyberium
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just reviewed my change i dont see where i could broke stacking rules. Can you say me how i can test that to reproduce it?
I have done ".go creature 17768" but i dont see sironas have any aura -> http://i.imgur.com/zz9Eypx.jpg
Is that npc should act like that video? -> https://www.youtube.com/watch?v=Z7qZT8tSUiY

@xfurry
Copy link
Member

@xfurry xfurry commented on 8f3082a May 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the npc needs to act like in the video.
However, you can't reproduce the issue on your side right now. First I need to push some ACID updates, then I will ask you to try again.

@xfurry
Copy link
Member

@xfurry xfurry commented on 8f3082a May 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyberium one more thing which is broken lately.
Creature summoning duration.
Usually when summoned by spell, the creature despawn timer is the one defined in the spell as Duration ID.
In the latest core it looks like it's infinite. Summoned creatures are not being despawned on timer anymore 😢

Please sign in to comment.