Skip to content

Commit

Permalink
Core side support for missing quest
Browse files Browse the repository at this point in the history 
missing Q 8354
  • Loading branch information
@Phatcat
NeatElves authored and Phatcat committed Oct 9, 2016
1 parent 803cc41 commit cc2690e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/game/ObjectMgr.cpp
View file
Expand Up @@ -4418,8 +4418,8 @@ void ObjectMgr::LoadQuests()
if (!quest)
continue;

// Exclude false positive of quest 10162
if (!quest->HasSpecialFlag(QUEST_SPECIAL_FLAG_EXPLORATION_OR_EVENT) && spellInfo->Id != 33824 && quest_id != 10162)
// Exclude false positive of quests 8354 & 10162
if (!quest->HasSpecialFlag(QUEST_SPECIAL_FLAG_EXPLORATION_OR_EVENT) && spellInfo->Id != 24875 && quest_id != 8354 && spellInfo->Id != 33824 && quest_id != 10162)
{
sLog.outErrorDb("Spell (id: %u) have SPELL_EFFECT_QUEST_COMPLETE for quest %u , but quest does not have SpecialFlags QUEST_SPECIAL_FLAG_EXPLORATION_OR_EVENT (2) set. Quest SpecialFlags should be corrected to enable this objective.", spellInfo->Id, quest_id);

Expand Down

4 comments on commit cc2690e

@Grz3s
Copy link
Member

@Grz3s Grz3s commented on cc2690e Oct 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also may be ok for
TBC (@killerwife)
Classic (@cala)
What u guys think?

@Laizerox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Grz3s maybe implement some kind of storage in database for these kind of conditions? Having them hardcoded is really bad idea.

@killerwife
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Grz3s If I understand correctly, the quest should not complete ONLY after spell being cast, there are secondary objectives?

@Grz3s
Copy link
Member

@Grz3s Grz3s commented on cc2690e Oct 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this question is to @NeatElves

Please sign in to comment.