-
Notifications
You must be signed in to change notification settings - Fork 293
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Yeah, should be like this. (1 / a) * b is the same as b / a
- Loading branch information
Showing
1 changed file
with
1 addition
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc5ddcf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasnt it (b/a)*b which is b^2/a and not b/a
cc5ddcf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, you are right stfx.
cc5ddcf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. No it wasn't.
9408c3e#diff-6e2ad27531ee8eb7bafce8a41909816aL3778
cc5ddcf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also how would that calculation make ANY sense whatsoever? delay * delay?
cc5ddcf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Phatcat Problem is that it still is not the same. Delay is not Float but UINT32, previously it was 1.0f * delay / mili, which means you were doing float division but now you are doing integer division. Either add (float) and brackets around delay or revert it to the previous state. Currently the expression is converted to float AFTER doing calculations, if I recall C basics correctly.
cc5ddcf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but that's a whole other issue isn't it? one completely unrelated to what stfx is saying, so it's not a counter argument to what I just said, it's a whole other problem altogether.
Also, I am not changing this 'on a huntch' - either be sure of what you're saying or be sure that it's still bugged.
cc5ddcf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I only looked at this commit. If both delay and in_milliseconds are integers then killerwife is correct that it now discards decimal digits.
cc5ddcf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, that I will change, not trying to be difficult.
I did not know that, but I am glad that I do now, thanks for educating me on this; because that's what's cmangos is about, right? teaching and encouraging eachother, right?
cc5ddcf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is why we give constructive feedback.