Skip to content

Commit

Permalink
Fix column number in sql update.
Browse files Browse the repository at this point in the history
  • Loading branch information
@cyberium
cyberium committed Aug 11, 2017
1 parent e6a4a63 commit d407b62
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion sql/updates/mangos/13957_01_mangos_gossip_menu_option.sql
View file
@@ -1,3 +1,4 @@
ALTER TABLE db_version CHANGE COLUMN required_13956_01_mangos_spell_chain_totems_typos required_13957_01_mangos_gossip_menu_option bit;

INSERT INTO `gossip_menu_option` VALUES('0','16','0','GOSSIP_OPTION_BOT','99','1','0','0','0','0','0',NULL,'0','0','0','0','0','0','0','0','0');
DELETE FROM gossip_menu_option WHERE menu_id=0 AND id=16;
INSERT INTO `gossip_menu_option` VALUES('0','16','0','GOSSIP_OPTION_BOT','99','1','0','0','0','0','0',NULL,'0');

6 comments on commit d407b62

@Grz3s
Copy link
Member

@Grz3s Grz3s commented on d407b62 Aug 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table gossip_menu_option for menu 0, id 16 has unknown option id 99. Option will not be used

@NeatElves
Copy link

@NeatElves NeatElves commented on d407b62 Aug 12, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Grz3s

Build Playerbot : Yes

And there is no message)

@cyberium
But still, if you use the gossip_menu_option - bot spawn & server is down(.
The command "/s .bot add BOTNAME" is working fine.

@cyberium
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it. How to replicate the crash by using gossip?

@NeatElves
Copy link

@NeatElves NeatElves commented on d407b62 Aug 12, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example: pour into the database and call the bot,
PlayerbotAI.DisableBots = 0

REPLACE INTO `creature_template` (`Entry`, `Name`, `SubName`, `IconName`, `MinLevel`, `MaxLevel`, `DifficultyEntry1`, `DifficultyEntry2`, `DifficultyEntry3`, `ModelId1`, `ModelId2`, `ModelId3`, `ModelId4`, `FactionAlliance`, `FactionHorde`, `Scale`, `Family`, `CreatureType`, `InhabitType`, `RegenerateStats`, `RacialLeader`, `NpcFlags`, `UnitFlags`, `DynamicFlags`, `ExtraFlags`, `CreatureTypeFlags`, `SpeedWalk`, `SpeedRun`, `UnitClass`, `Rank`, `Expansion`, `HealthMultiplier`, `PowerMultiplier`, `DamageMultiplier`, `DamageVariance`, `ArmorMultiplier`, `ExperienceMultiplier`, `MinLevelHealth`, `MaxLevelHealth`, `MinLevelMana`, `MaxLevelMana`, `MinMeleeDmg`, `MaxMeleeDmg`, `MinRangedDmg`, `MaxRangedDmg`, `Armor`, `MeleeAttackPower`, `RangedAttackPower`, `MeleeBaseAttackTime`, `RangedBaseAttackTime`, `DamageSchool`, `MinLootGold`, `MaxLootGold`, `LootId`, `PickpocketLootId`, `SkinningLootId`, `KillCredit1`, `KillCredit2`, `QuestItem1`, `QuestItem2`, `QuestItem3`, `QuestItem4`, `QuestItem5`, `QuestItem6`, `MechanicImmuneMask`, `ResistanceHoly`, `ResistanceFire`, `ResistanceNature`, `ResistanceFrost`, `ResistanceShadow`, `ResistanceArcane`, `PetSpellDataId`, `MovementType`, `MovementTemplateId`, `TrainerType`, `TrainerSpell`, `TrainerClass`, `TrainerRace`, `TrainerTemplateId`, `VendorTemplateId`, `EquipmentTemplateId`, `VehicleTemplateId`, `GossipMenuId`, `AIName`, `ScriptName`) VALUES
(99001, 'Slappy McFry', 'The Bot Recruiter', '', 59, 61, 0, 0, 0, 18, 0, 0, 0, 35, 35, 1, 0, 7, 3, 1, 0, 1, 0, 0, 0, 0, 1.48, 1.14286, 2, 0, -1, 1, 1, 1.4, 1, 1, 1, 6700, 24000, 5598, 5875, 98, 146, 78, 117, 4009, 37, 30, 1500, 1500, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 59110, '', '');
REPLACE INTO `gossip_menu` (`entry`, `text_id`, `condition_id`) VALUES
(59110, 68, 0);
REPLACE INTO `gossip_menu_option` (`menu_id`, `id`, `option_icon`, `option_text`, `option_id`, `npc_option_npcflag`, `action_menu_id`, `action_poi_id`, `action_script_id`, `box_coded`, `box_money`, `box_text`, `condition_id`) VALUES
(59110, 16, 0, 'GOSSIP_OPTION_BOT', 99, 1, 0, 0, 0, 0, 0, NULL, 0);
REPLACE INTO `creature` (`guid`, `id`, `map`, `spawnMask`, `phaseMask`, `modelid`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecsmin`, `spawntimesecsmax`, `spawndist`, `currentwaypoint`, `curhealth`, `curmana`, `DeathState`, `MovementType`) VALUES
(200177, 99001, 0, 1, 1, 0, 0, -13226, 232.678, 33.3208, 4.20816, 300, 300, 0, 0, 6700, 5598, 0, 0);

p.s. The option is visible in all NPCs that have a gossip.))

@Grz3s
Copy link
Member

@Grz3s Grz3s commented on d407b62 Aug 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NeatElves .. but without BOT we also shouldn't receive this error. (If BOT is req. then make it compile with it as default)
Another problem without BOT:
Every NPC with gossip (no diff if he has gossip_options or not.. will throw error if we'll interact with them)

Creature entry 22919 have unknown gossip option 99 for menu 0 -- this one has no gossip_options at all
Creature entry 22215 have unknown gossip option 99 for menu 0 -- this one also
... and carries on.. with every clicked npc

@NeatElves
Copy link

@NeatElves NeatElves commented on d407b62 Aug 13, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Grz3s.. I agree

This should not be.

wowscrnshot_081217_110708
wowscrnshot_081217_110804
wowscrnshot_081217_110925
The text should appear at the NPC, if there is an entry in the gossip_options

Please sign in to comment.