Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add partial support for quests 5821 & 5943
* Both Gizelton Caravan escort quests can now be taken and completed in Desolace. * Quests failure is not fully handled: death of Rigger or one of the two kodos will not trigger quest failure like it should
- Loading branch information
Showing
2 changed files
with
299 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4c562e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assumes some DB ground work similar to:
classicdb/database@b9a51fb for the waypoints
classicdb/database@936a9f2 for the DB Scripts
Also, additional suggested SQL code for this SD2 update:
f4c562e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies, I forgot to thank:
f4c562e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome! much love to you
f4c562e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cala this commit creates a crash...
My core doesn't start since you pushed this one.
And I was almost to blame @namreeb for his latest commits, but actually your script creates problems.
f4c562e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crash is fixed here: 1cfffe8
@cala here are a few comments:
Why do we need AI part for npc_rigger_gizelton since npc_cork_gizelton handles everything?
Shouldn't we have a check similar to
bool npc_escortAI::IsPlayerOrGroupInRange()
to check if the player that started the quest is still around? After all this should behave similar to an escort quest.f4c562e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xfurry I'm sorry it caused a crash. I did not have one while testing or I would not have push it. Thank you very much for fixing it and improving the script (I did not notice it was that dirty when I pushed it: I spent too much time reworking it again and again). 👍
Yes, we should. But as noted in the commits notes, I was unable to have a working "fail quest" feature, would it be from out ranging NPCs or having them dying. So I did not include the non-working function I had for that. Now that you have fixed the script and gave a better access to the player object, I can try to handle the various "fail quest" scenarii in a proper way.
In the current state of the script, we do not need it, indeed. I used it in a previous version of the script to have npc_rigger_gizelton informing npc_rigger_gizelton that it should fail the quest (mainly due to npc_rigger_gizelton's death) and it did not remove it. Also, depending on how npc_rigger_gizelton will handle quest failure, we could also use an EventAI throw from npc_rigger_gizelton to npc_cork_gizelton.
There is still a lot of work to do on this script, but at least, the quests are implemented and completable now. Thank you again for your help on the matter. 😄